Update testing dependencies and fix tests for mypy 1.20#143
Merged
Conversation
binaryDiv
commented
Apr 8, 2026
| [tool.setuptools_scm] | ||
| write_to = "src/validataclass/_version.py" | ||
| version_scheme = "post-release" | ||
| version_scheme = "no-guess-dev" |
Contributor
Author
There was a problem hiding this comment.
Note: "post-release" has been deprecated for a while now, "no-guess-dev" is the recommended replacement. It doesn't affect normal builds, only local development builds.
binaryDiv
commented
Apr 8, 2026
| classifiers = | ||
| Development Status :: 4 - Beta | ||
| Intended Audience :: Developers | ||
| License :: OSI Approved :: MIT License |
Contributor
Author
There was a problem hiding this comment.
Note: This was removed because license classifiers are deprecated. We still set license = MIT in the metadata above.
ninanomenon
approved these changes
Apr 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please note that the target branch is
dev-mypyinstead of main. This will likely be the last PR on dev-mypy, after this is merged I'll merge dev-mypy to main.mypy introduced some changes in version 1.20 which causes error messages (and
reveal_typeoutput) to look different than before. Most of this is just stripping thebuiltins.from builtin types (e.g.intinstead ofbuiltins.int), which is a change I quite like because it improves readability. But it also means I had to update a lot in the typing tests. 😅This PR updates all testing dependencies to their latest versions (including mypy 1.20.0) and fixes anything that broke because of that.
Since the mypy update broke our pipelines, I've also decided to pin the versions of all testing dependencies to minor versions instead of major versions (it used to be
mypy ~= 1.19which is equivalent tomypy >= 1.19, < 2.0, now we specify still a minimum version but only allow patch level updates).I also did some smaller changes in the test environment (e.g. modernizing the tox config a little bit, fixed some deprecated config options), and updated the GitHub Actions versions.