optimize and minimize hx-on code#3783
Merged
1cg merged 2 commits intobigskysoftware:four-devfrom May 6, 2026
Merged
Conversation
Contributor
|
Thanks Michael! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The new hx-on modifier code has been added but it could do with some code optimization to minimize the final bundle size.
metadata character code can be simplified
using map to create a mod object with true properties per mods string allows us to remove the has helper and use it as a object access much simpler. Also this means we can safely just pass this mod object to the event listener to set all capture, passive, once and it will ignore the rest.
Also removed the removeEventListener since it is not needed once we pass once option.
Finally put back
Which was recently removed accidently which is still used by json extensions to access the raw hx-vals object data with json types preserved.
Corresponding issue:
Testing
No real functional changes and tests still all pass
Checklist
masterfor website changes,devforsource changes)
approved via an issue
npm run test) and verified that it succeeded