Skip to content

feat: enables client-side navigation in Makeswift builder#2913

Open
agurtovoy wants to merge 1 commit into
integrations/makeswiftfrom
aleksey/makeswift-builder-client-side-navigation
Open

feat: enables client-side navigation in Makeswift builder#2913
agurtovoy wants to merge 1 commit into
integrations/makeswiftfrom
aleksey/makeswift-builder-client-side-navigation

Conversation

@agurtovoy
Copy link
Copy Markdown
Contributor

@agurtovoy agurtovoy commented Mar 9, 2026

What/Why?

Enables client-side navigation in Makeswift builder by upgrading Catalyst to the latest Makeswift runtime.

Testing

Kapture.2026-05-19.at.14.33.41.mp4

Migration

N/A

@vercel
Copy link
Copy Markdown

vercel Bot commented Mar 9, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
catalyst Ready Ready Preview, Comment May 19, 2026 6:14pm

Request Review

@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented Mar 9, 2026

🦋 Changeset detected

Latest commit: 7aff6ac

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@bigcommerce/catalyst-makeswift Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Comment thread core/package.json Outdated
Copy link
Copy Markdown
Contributor

@jorgemoya jorgemoya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we include a changeset?

@jorgemoya
Copy link
Copy Markdown
Contributor

jorgemoya commented Mar 9, 2026

Tagging with do not merge until we have that released runtime version.

Edit: nevermind, it's a draft PR 🤦

@agurtovoy agurtovoy force-pushed the aleksey/makeswift-builder-client-side-navigation branch from 22c8123 to 6981c20 Compare May 18, 2026 19:09
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 18, 2026

Bundle Size Report

Comparing against baseline from 20204c8 (2026-05-19).

Metric Baseline Current Delta
Total JS 695 kB 703.9 kB +8.9 kB (+1.3%)

Per-Route First Load JS

Route Baseline Current Delta
/(default)/(auth)/change-password/page 608.4 kB 611.3 kB +2.9 kB (+0.5%)
/(default)/(auth)/login/forgot-password/page 607.5 kB 610.4 kB +2.9 kB (+0.5%)
/(default)/(auth)/login/page 608.1 kB 611 kB +2.9 kB (+0.5%)
/(default)/(auth)/register/page 609.5 kB 612.4 kB +2.9 kB (+0.5%)
/(default)/(faceted)/brand/[slug]/page 614.3 kB 617.2 kB +2.9 kB (+0.5%)
/(default)/(faceted)/category/[slug]/page 622.5 kB 625.4 kB +2.9 kB (+0.5%)
/(default)/(faceted)/search/page 614.3 kB 617.2 kB +2.9 kB (+0.5%)
/(default)/[...rest]/page 609.5 kB 612.4 kB +2.9 kB (+0.5%)
/(default)/account/addresses/page 612 kB 614.9 kB +2.9 kB (+0.5%)
/(default)/account/orders/[id]/page 607.1 kB 610 kB +2.9 kB (+0.5%)
/(default)/account/orders/page 608 kB 610.9 kB +2.9 kB (+0.5%)
/(default)/account/settings/page 611.5 kB 614.4 kB +2.9 kB (+0.5%)
/(default)/account/wishlists/[id]/page 616.7 kB 619.6 kB +2.9 kB (+0.5%)
/(default)/account/wishlists/page 611.5 kB 614.4 kB +2.9 kB (+0.5%)
/(default)/blog/[blogId]/page 609.5 kB 612.4 kB +2.9 kB (+0.5%)
/(default)/blog/page 610.2 kB 613.1 kB +2.9 kB (+0.5%)
/(default)/cart/page 616.1 kB 619 kB +2.9 kB (+0.5%)
/(default)/compare/page 610.8 kB 613.7 kB +2.9 kB (+0.5%)
/(default)/gift-certificates/balance/page 611.3 kB 614.2 kB +2.9 kB (+0.5%)
/(default)/gift-certificates/page 609.5 kB 612.4 kB +2.9 kB (+0.5%)
/(default)/gift-certificates/purchase/page 611.2 kB 614.1 kB +2.9 kB (+0.5%)
/(default)/page 609.5 kB 612.4 kB +2.9 kB (+0.5%)
/(default)/product/[slug]/page 622.5 kB 625.5 kB +3 kB (+0.5%)
/(default)/webpages/[id]/contact/page 612.6 kB 615.6 kB +3 kB (+0.5%)
/(default)/webpages/[id]/normal/page 610 kB 612.9 kB +2.9 kB (+0.5%)
/(default)/wishlist/[token]/page 613.4 kB 616.4 kB +3 kB (+0.5%)
/maintenance/page 606 kB 609 kB +3 kB (+0.5%)
/_not-found/page 560.6 kB 563.5 kB +2.9 kB (+0.5%)

Threshold: 5% increase. Routes with ⚠️ exceed the threshold.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 18, 2026

Unlighthouse Performance Comparison — Vercel

Comparing PR preview deployment Unlighthouse scores vs production Unlighthouse scores.

Summary Score

Aggregate score across all categories as reported by Unlighthouse.

Prod Desktop Prod Mobile Preview Desktop Preview Mobile
Score 87 90 91 94

Category Scores

Category Prod Desktop Prod Mobile Preview Desktop Preview Mobile
Performance 69 77 75 79
Accessibility 91 91 95 95
Best Practices 95 100 100 100
SEO 89 89 100 100

Core Web Vitals

Metric Prod Desktop Prod Mobile Preview Desktop Preview Mobile
LCP 6.7 s 6.3 s 4.1 s 5.4 s
CLS 0.03 0 0 0
FCP 1.1 s 1.1 s 1.2 s 1.2 s
TBT 20 ms 30 ms 20 ms 10 ms
Max Potential FID 90 ms 90 ms 80 ms 70 ms
Time to Interactive 7.0 s 7.8 s 5.9 s 5.7 s

Full Unlighthouse report →

@agurtovoy agurtovoy force-pushed the aleksey/makeswift-builder-client-side-navigation branch from 6981c20 to adda536 Compare May 19, 2026 18:04
Enabled by upgrading to the latest Makeswift runtime
@agurtovoy agurtovoy force-pushed the aleksey/makeswift-builder-client-side-navigation branch from adda536 to 7aff6ac Compare May 19, 2026 18:13
Comment thread core/package.json
"@conform-to/zod": "^1.6.1",
"@icons-pack/react-simple-icons": "^11.2.0",
"@makeswift/runtime": "0.26.4",
"@makeswift/runtime": "0.28.5",
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@agurtovoy agurtovoy marked this pull request as ready for review May 19, 2026 19:41
@agurtovoy agurtovoy requested a review from a team as a code owner May 19, 2026 19:41
Copy link
Copy Markdown
Contributor

@parthshahp parthshahp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants