Repository navigation
fix(BBButton): make the subtle neutral button transparent - #122
Merged
Arthurk12 merged 1 commit intoNov 16, 2026
Merged
Conversation
The subtle neutral button reuses the primary neutral colors: an opaque white background (colorWhite) with --color-gray text, while subtle default sits on a transparent background. BigBlueButton 4.1's native dark theme sets both --color-gray and --color-white to #FFFFFF, since --color-white is its text color there, so the button renders white on white. In the light theme it shows as a white pill on any surface that isn't white. Give subtle neutral the transparent background, light-gray hover and icon-default outline of subtle default, keeping only its --color-gray text. The hover then follows --color-light-gray, which the 4.1 dark theme already sets to a dark surface.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
The subtle neutral button reuses the primary neutral colors: an opaque white background (colorWhite) with --color-gray text, while subtle default sits on a transparent background. BigBlueButton 4.1's native dark theme sets both --color-gray and --color-white to #FFFFFF, since --color-white is its text color there, so the button renders white on white. In the light theme it shows as a white pill on any surface that isn't white.
Give subtle neutral the transparent background, light-gray hover and icon-default outline of subtle default, keeping only its --color-gray text. The hover then follows --color-light-gray, which the 4.1 dark theme already sets to a dark surface.
Before:

After:

Closes Issue(s)
Closes #100