Skip to content

fix(a11y): activate thumbnails, chat avatars and the title with Space - #389

Merged
antobinary merged 2 commits into
bigbluebutton:developfrom
germanocaumo:fix-keyboard-activation
Nov 18, 2026
Merged

antobinary merged 2 commits into
bigbluebutton:developfrom
germanocaumo:fix-keyboard-activation

Conversation

@germanocaumo

@germanocaumo germanocaumo commented Nov 17, 2026 •

Copy link
Copy Markdown
Contributor

What does this PR do?

Lets the thumbnails, the chat avatars and the recording title (which opens the About dialog) be activated with Space as well as Enter, as buttons are, gives them the button role, and gives the title an accessible name and description.

  • Activation: these focusable div/span elements only reacted to Enter, through React's deprecated onKeyPress. They now use onKeyDown with handleOnKeyActivation, which replaces handleOnEnterPress (it had no other callers). It takes Enter and Space and prevents the default, so Space doesn't scroll the list around them. Keys with Alt, Ctrl or Meta are left alone: keydown, unlike keypress, fires for the Alt+Shift+Enter play shortcut, which would otherwise also seek to a focused thumbnail.
  • Title: it passed aria, the Button component's prop, to a plain span, where it is no attribute, so it had no accessible name at all. With the button role, its text (meeting name and date) is now its name, and the title attribute carries the "About" hint: screen readers read it as the description and mouse users get it as a tooltip. aria-label="About" would have replaced the meeting name, which is also the visible label; aria-description trips the jsx-a11y/role-supports-aria-props lint rule.

Also part of #376, which bundles it with a redesign.

How to test

Tab to a thumbnail, a chat avatar or the title and press Space (Chrome and Firefox):

develop this PR
Thumbnail #6 + Space nothing jumps to the slide (0 s → 1481.8 s)
Thumbnail #6 + Enter jumps to the slide jumps to the slide
Chat avatar + Space nothing jumps to the message (0 s → 684.3 s)
Title + Space nothing opens About
Thumbnail #2 focused + Alt+Shift+Enter at 600 s toggles play toggles play, stays at 600 s
Role of thumbnails, chat avatars, title none button

The title in the accessibility tree:

develop this PR
Chrome not exposed button "Salão de Conferências - 10/19/2026", description "About"
Firefox generic, no name button "Salão de Conferências - 10/19/2026", description "About"
WebKit group, no name button "Salão de Conferências - 10/19/2026" (Playwright's WebKit snapshot doesn't report descriptions)

src/utils/data/handlers.test.js covers the handler, including the modifiers.

Changelog

  • Technical: handleOnEnterPress is replaced by handleOnKeyActivation (Enter and Space on keydown, no modifiers)
  • User-facing: thumbnails, chat avatars and the recording title can be activated with Space; screen readers announce them as buttons and read the recording title's name

These elements act as buttons but only reacted to Enter, through the
deprecated keypress event. Activate them with Enter and Space on
keydown, like a button, and give them the button role. Keys with a
modifier are left to the shortcuts (Alt+Shift+Enter toggles play).
@germanocaumo
germanocaumo force-pushed the fix-keyboard-activation branch from bee5a8b to 4a0287c Compare November 17, 2026 17:54
The title passed `aria`, the Button component's prop, to a plain span,
where it is no attribute at all, so the "About" hint never reached
anyone. Use the title attribute: the meeting name stays the button's
name, "About" becomes its description for screen readers, and a tooltip
for the mouse.
@germanocaumo
germanocaumo force-pushed the fix-keyboard-activation branch from 4a0287c to df5f86b Compare November 17, 2026 18:18
@antobinary
antobinary merged commit aeec7db into bigbluebutton:develop Nov 18, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants