Repository navigation
fix(a11y): activate thumbnails, chat avatars and the title with Space - #389
Merged
antobinary merged 2 commits intoNov 18, 2026
Merged
Conversation
These elements act as buttons but only reacted to Enter, through the deprecated keypress event. Activate them with Enter and Space on keydown, like a button, and give them the button role. Keys with a modifier are left to the shortcuts (Alt+Shift+Enter toggles play).
germanocaumo
force-pushed
the
fix-keyboard-activation
branch
from
November 17, 2026 17:54
bee5a8b to
4a0287c
Compare
The title passed `aria`, the Button component's prop, to a plain span, where it is no attribute at all, so the "About" hint never reached anyone. Use the title attribute: the meeting name stays the button's name, "About" becomes its description for screen readers, and a tooltip for the mouse.
germanocaumo
force-pushed
the
fix-keyboard-activation
branch
from
November 17, 2026 18:18
4a0287c to
df5f86b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Lets the thumbnails, the chat avatars and the recording title (which opens the About dialog) be activated with Space as well as Enter, as buttons are, gives them the
buttonrole, and gives the title an accessible name and description.div/spanelements only reacted to Enter, through React's deprecatedonKeyPress. They now useonKeyDownwithhandleOnKeyActivation, which replaceshandleOnEnterPress(it had no other callers). It takes Enter and Space and prevents the default, so Space doesn't scroll the list around them. Keys with Alt, Ctrl or Meta are left alone:keydown, unlikekeypress, fires for the Alt+Shift+Enter play shortcut, which would otherwise also seek to a focused thumbnail.aria, theButtoncomponent's prop, to a plainspan, where it is no attribute, so it had no accessible name at all. With thebuttonrole, its text (meeting name and date) is now its name, and thetitleattribute carries the "About" hint: screen readers read it as the description and mouse users get it as a tooltip.aria-label="About"would have replaced the meeting name, which is also the visible label;aria-descriptiontrips thejsx-a11y/role-supports-aria-propslint rule.Also part of #376, which bundles it with a redesign.
How to test
Tab to a thumbnail, a chat avatar or the title and press Space (Chrome and Firefox):
buttonThe title in the accessibility tree:
src/utils/data/handlers.test.jscovers the handler, including the modifiers.Changelog
handleOnEnterPressis replaced byhandleOnKeyActivation(Enter and Space on keydown, no modifiers)