Skip to content

fix(shortcuts): match letters on macOS and non-Latin layouts, skip text fields - #386

Merged
antobinary merged 1 commit into
bigbluebutton:developfrom
germanocaumo:fix-shortcuts-physical-key
Nov 18, 2026
Merged

antobinary merged 1 commit into
bigbluebutton:developfrom
germanocaumo:fix-shortcuts-physical-key

Conversation

@germanocaumo

@germanocaumo germanocaumo commented Nov 17, 2026 •

Copy link
Copy Markdown
Contributor

What does this PR do?

Makes the Alt+Shift letter shortcuts (K fullscreen, L side section, M swap) work on macOS and on non-Latin keyboard layouts, and stops the shortcuts from firing while typing in a text field.

The handler compared event.key with the configured letter. With Alt held, macOS types another character (Option+Shift+K types the Apple logo, U+F8FF; Option+Shift+L types Ò), and non-Latin layouts type their own letters (Д for L on a Russian layout), so these shortcuts never fired there. When the character typed isn't a Latin letter, the key's position (event.code) is matched instead. Latin layouts keep matching the character, so on Dvorak or AZERTY the shortcut stays on the key labelled with that letter.

Text fields now keep their own keys: Alt+Shift+Left in the search field (word selection on macOS) also sought the recording back 15 s.

Also part of #376, which bundles it with a redesign.

How to test

Keydown events as each layout delivers them, dispatched on the player:

Keys key / code develop this PR
Alt+Shift+L, US layout L / KeyL toggles the section toggles the section
Option+Shift+L, macOS Ò / KeyL nothing toggles the section
Alt+Shift+L, Russian layout Д / KeyL nothing toggles the section
Option+Shift+K, macOS U+F8FF (Apple logo) / KeyK nothing toggles fullscreen
Alt+Shift+Left in the search field ArrowLeft seeks 600 s → 585 s stays at 600 s

src/utils/shortcuts.test.js dispatches the keydown events of each case (macOS, Russian, Dvorak, named keys) and the text field case.

Changelog

  • Technical: Alt+Shift letter shortcuts match event.code when the typed character is not a Latin letter; shortcuts ignore keydown in text fields
  • User-facing: keyboard shortcuts work on macOS and non-Latin keyboard layouts

…xt fields

The shortcuts compared the character typed with the configured letter.
With Alt held, macOS types another character (Option+Shift+K types the
Apple logo), and non-Latin layouts type their own letters, so the letter
shortcuts never fired there. When the character typed is not a Latin
letter, match the key's position instead.

Text fields also keep their own Alt+Shift keys: Alt+Shift+Left in the
search field used to seek the recording back.
@germanocaumo
germanocaumo force-pushed the fix-shortcuts-physical-key branch from d91a5c5 to e6818a7 Compare November 17, 2026 17:54
@germanocaumo germanocaumo changed the title fix(shortcuts): match Alt+Shift letters on macOS and non-Latin layouts fix(shortcuts): match letters on macOS and non-Latin layouts, skip text fields Nov 17, 2026
@antobinary
antobinary merged commit 762a9ee into bigbluebutton:develop Nov 18, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants