Repository navigation
fix(captions): show the captions and the CC button in Safari - #385
Merged
antobinary merged 1 commit intoNov 18, 2026
Merged
Conversation
video.js only adds the tracks passed in its options when it renders the captions itself. Safari defaults to native text tracks, so it had no caption tracks and the CC button stayed hidden. Let video.js render the captions in every browser.
germanocaumo
force-pushed
the
fix-safari-captions
branch
from
November 17, 2026 17:54
3789b91 to
1d5e537
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Shows the captions and the CC button in Safari.
video.js 7 only adds the tracks passed in its
tracksoption when it renders the captions itself (TextTrackDisplayskips them when the tech uses native text tracks). video.js uses native text tracks in Safari (and Chrome on iOS), so there the webcams player had no caption tracks and the CC button stayed hidden. Settinghtml5.nativeTextTracks: falselets video.js render the captions in every browser, as it already does in Chrome and Firefox.The webcams video plays inline (
playsInline) and the player has no native fullscreen toggle, so emulated captions don't lose anything to the iOS native fullscreen player.Also part of #376, which bundles it with a redesign.
How to test
Open a recording with captions in Safari (or Playwright WebKit), turn the captions on and seek to a cue.
WebKit, captions on, at 9 s (chat pixelated):
The caption spans the page width in every browser; that's the existing caption layout, unchanged here.
Checked with Playwright WebKit 26 on Linux, not on a real Safari or iOS device.
Changelog