Skip to content

Keep clipboard panel above full-screen apps - #52

Merged
bifrost-proxy merged 1 commit into
mainfrom
codex/fix-fullscreen-overlay-1.7.7
Aug 23, 2026
Merged

bifrost-proxy merged 1 commit into
mainfrom
codex/fix-fullscreen-overlay-1.7.7

Conversation

@bifrost-proxy

Copy link
Copy Markdown
Owner

Summary

  • raise the clipboard panel to the assistive-technology overlay level
  • attach every hotkey presentation to the active full-screen Space and verify WindowServer visibility
  • recover from stale visibility, Space transitions, occlusion, and interrupted dismissal races
  • add a deterministic full-screen overlay regression to CI and Release

Verification

  • swift build
  • localization/history/settings/updater/appearance/translation verifiers
  • panel overlay recovery and panel reconciliation regressions
  • isolated and installed three-launch UI regressions
  • real iCloud three-launch regression via LaunchServices with cleanup
  • Universal 1.7.7 (50) DMG/signature/architecture verification
  • memory performance regression
  • strip functional/performance assertions (local RSS gate also fails on unmodified 1.7.6 baseline)

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 6c2f223dd3

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment on lines +456 to +458
@objc private func handleApplicationActivation() {
guard window?.isVisible == true, !isDismissing else { return }
beginVisibilityRecovery()

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Avoid reclaiming focus when another app activates

When the user switches applications with Cmd-Tab while the panel is open, this handler calls beginVisibilityRecovery(), which synchronously reaches restorePresentationPolicyAndOrdering() and panel.makeKey(). That can run before the deferred windowDidResignKey check, causing that check to see the panel as key again and abort its auto-hide, so Pesty steals focus back from the newly activated application. Application activation should only initiate reattachment after confirming the panel is detached, without immediately making it key.

Useful? React with 👍 / 👎.

Comment on lines +196 to +198
guard let self,
self.presentationGeneration == generation,
self.isDismissing else { return }

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Resolve callbacks when presentation interrupts dismissal

If show() runs during the 80 ms hide animation, it increments presentationGeneration, so this guard discards the hide completion without removing or invoking hideCompletions. For pasteItem, that suppresses the requested paste, and the retained callback then executes during a later unrelated hide, potentially pasting the stale item into the previously captured application. An interrupted dismissal must explicitly cancel or complete its queued callbacks rather than leaving them for the next hide.

Useful? React with 👍 / 👎.

@bifrost-proxy
bifrost-proxy merged commit 60ca3a4 into main Aug 23, 2026
1 check passed
@bifrost-proxy
bifrost-proxy deleted the codex/fix-fullscreen-overlay-1.7.7 branch August 23, 2026 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant