fix: auto-resolve sync conflicts and hide Dock icon by default - #118
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: b994a5b9e0
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
|
||
| // UI & Behavior | ||
| "IsMenuBarOnly": false, | ||
| "IsMenuBarOnly": true, |
There was a problem hiding this comment.
Preserve the legacy Dock setting for existing profiles
On upgrade, established users who never toggled “Hide Dock Icon” have no persistent IsMenuBarOnly value because the previous register(defaults:) value was only a registration-domain fallback. Changing that fallback to true therefore makes those existing profiles start in menu-bar-only mode and hides their main window, rather than limiting the new behavior to fresh installs as intended. Add an installation-aware migration that persists false for established profiles lacking the key before registering the new default.
AGENTS.md reference: AGENTS.md:L153-L158
Useful? React with 👍 / 👎.
Summary
LSUIElementat launch so the icon does not flash before preferences loadUser-visible behavior
Compatibility and privacy
Risk and rollback
Verification
git diff --checkmake checkxcodebuild test -project VoiceInk.xcodeproj -scheme VoiceInk -destination 'platform=macOS,arch=arm64' -only-testing:VoiceInkTests -parallel-testing-enabled NO CODE_SIGNING_ALLOWED=NO ENABLE_TESTABILITY=YES