Safely insert type erased component - #25320
Open
Person-93 wants to merge 5 commits into
Open
Conversation
Person-93
force-pushed
the
safely-insert-component-by-id
branch
from
August 7, 2026 05:06
51142fe to
6f731e6
Compare
Person-93
force-pushed
the
safely-insert-component-by-id
branch
from
August 7, 2026 05:10
6f731e6 to
0bb6d39
Compare
urben1680
suggested changes
Aug 7, 2026
Contributor
Author
Like I said, I want a safe way to insert type-erased components. Two use cases:
|
Contributor
Author
I've added the unit tests and I've fixed a segfault when the component is a ZST. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Objective
Bevy has a public API for inserting components by id, but it's unsafe. https://docs.rs/bevy/latest/bevy/prelude/struct.EntityCommands.html#method.insert_by_id
Solution
This PR adds a safe wrapper around it. The user creates a
ComponentInserterwhen the type is known. Later, the user can use it to insert the component.Testing
I added an example in the docs which will be run as a doctest.