Skip to content

feat: handle comment line for parse and stringify#213

Open
NamPNQ wants to merge 1 commit into
bevry:masterfrom
NamPNQ:feat/handle-comment-line
Open

feat: handle comment line for parse and stringify#213
NamPNQ wants to merge 1 commit into
bevry:masterfrom
NamPNQ:feat/handle-comment-line

Conversation

@NamPNQ

@NamPNQ NamPNQ commented Apr 19, 2023

Copy link
Copy Markdown
Contributor

This PR will handle comment line

For simply I don't write a complicated parser to handle it, I just use symbol for handle line with comment

The benefits of use it is didn't break our object when pass to JSON.stringify

This PR also fix tests and add test case for handle comment line correctly

Close #192

@balupton

balupton commented Nov 29, 2023

Copy link
Copy Markdown
Member

@NamPNQ looks good, I'll rebase and merge sometime after my current batch of work

@balupton

Copy link
Copy Markdown
Member

What are examples of symbol comments outside of parsed envfiles? I've never seem that stuff before and there isn't tests for stringifying such.

@balupton

Copy link
Copy Markdown
Member

@gonzaloriestra can you review and resolve this?

@gonzaloriestra

Copy link
Copy Markdown
Contributor

I'd love to help, but unfortunately I don't have time for it right now... I created the other PR because we needed that in Shopify... Sorry!

@balupton

balupton commented Feb 28, 2024

Copy link
Copy Markdown
Member

@gonzaloriestra no worries then, I'll probably get to it in April or May with my current backlog and availability. Would @Shopify be interested in sponsoring to get their support in all my project's readmes https://github.com/sponsors/balupton — thanks again for your PR!

@NamPNQ

NamPNQ commented Mar 13, 2024

Copy link
Copy Markdown
Contributor Author

What are examples of symbol comments outside of parsed envfiles? I've never seem that stuff before and there isn't tests for stringifying such.

@balupton Hey, I'm a bit confused. Could you rephrase that for me? Or just give me an example

@balupton

Copy link
Copy Markdown
Member

@NamPNQ PR just needs tests and docs really

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

maintain comments when parsing

3 participants