Repository navigation
Drop the ArrayDeque spec workaround, OpenJML 21.0.29 has the fix - #188
Merged
Merged
Conversation
OpenJML 21.0.29 also ships the RAC fix for java/util/ArrayDeque.jml (OpenJML/OpenJML#1012, Specs 43ab561: the containsNull invariant is //-RAC@), not only the AtomicLong one. Verified on the unmodified 21.0.29 Ubuntu distribution with this repository's main (673a5a9): RAC compile clean, full suite 285/285 against the RAC classes with ArrayDeque.jml in place. setup-openjml therefore deletes no bundled spec any more (fixups v3, new cache key); the guarded jdk/release repair stays. Also narrowed down why the four class invariants still break RAC on 21.0.29: an inner-class method calling an outer instance method without a qualifier (SBOutputStream.write -> writeSingleByte(b)) makes RAC check the callee's invariant on the inner object instead of StreamBuffer.this (NoSuchMethodError on Inner.JML$INV$$<n>()); Outer.this.m() runs clean. TODO.md has the reproducer; CLAUDE.md and the .jml header say so. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01YE4Dk1iKXes2PZ7jzjL5cC
bernardladenthin
had a problem deploying
to
maven-central
October 20, 2026 23:17 — with 
GitHub Actions
Failure
GitHub Actions
Failure
bernardladenthin
had a problem deploying
to
maven-central
October 20, 2026 23:17 — with
GitHub Actions
Failure
GitHub Actions
Failure
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #188 +/- ##
=========================================
Coverage 96.99% 96.99%
Complexity 116 116
=========================================
Files 1 1
Lines 266 266
Branches 29 29
=========================================
Hits 258 258
Misses 2 2
Partials 6 6 ☔ View full report in Codecov by Harness. |
|
Coverage is 99.248% — chore/openjml-21.0.29-arraydeque into main. No base build found for |
bernardladenthin
pushed a commit
that referenced
this pull request
Oct 21, 2026
PR #188 (OpenJML 21.0.29 fixups v3: no bundled spec deleted at install any more) merged first; the CHANGELOG and CLAUDE.md entries of both sides are kept, main's corrected facts replacing the branch's "ArrayDeque.jml still deleted" bullet. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01VBFFnrhtvXiUeyxjmUc4R2
bernardladenthin
pushed a commit
that referenced
this pull request
Oct 21, 2026
…e spec-deletion re-try from TODO.md close() takes bufferLock since the write/close fix, and a trim start or end signal is released under that lock: a release() that waits for a read, write or close of this buffer would hold close() on another thread behind it. The Javadoc of close() and of the two add*Signal methods say so. TODO.md's "on every OpenJML upgrade" bullet still asked to re-try dropping "the two spec-file deletions"; since PR #188 (fixups v3) the setup action deletes none. Both found by the review of PR #189. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01VBFFnrhtvXiUeyxjmUc4R2
5 of 6 tasks
This branch had an error being deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
rmofArrayDeque.jmlas "still broken in 21.0.29". It is not: 21.0.29 ships the RAC fix from RAC: 9 bundled specs don't compile under --rac, inner-class invariants, and related findings (from streambuffer) OpenJML/OpenJML#1012 (Specs43ab561,containsNullis//-RAC@).setup-openjmlnow deletes no bundled spec at all (fixups v3, new cache key). The guardedjdk/releaserepair stays; it does nothing on 21.0.29.SBOutputStream.write→writeSingleByte(b)), and RAC then checks the callee's invariant on the inner object instead ofStreamBuffer.this. The result isNoSuchMethodErroronInner.JML$INV$$<n>();Outer.this.m()runs clean. TODO.md has the 7-line reproducer; CLAUDE.md, the.jmlheader and CHANGELOG are updated.Test plan
mainat673a5a9, run as the workflow runs it: RAC compile clean and instrumented,mvn -P jml-rac test285/285 withArrayDeque.jmlin placeaction.ymlparses;check-run-scripts.pycleanRelated issues / PRs
Refs OpenJML/OpenJML#1012, #187.
Checklist
CONTRIBUTING.mdandCODE_OF_CONDUCT.mdSECURITY.md)🤖 Generated with Claude Code
https://claude.ai/code/session_01YE4Dk1iKXes2PZ7jzjL5cC