Repository navigation
WebUI license texts: LF digest, a hard check on every run and every PR - #572
Merged
Merged
Conversation
The release run of v6.0.0 (40238595195) failed in build-webui: the texts in llama/legal/natives/webui-npm were generated from a Windows checkout of llama.cpp, so LOCKFILE.sha256 recorded the digest of the CRLF lockfile (ca12fa34) while CI's Linux checkout of the same commit hashes d4f8f7d8. The package list itself is right: same lockfile, other line ends. - lockfile_digest hashes the lockfile with LF line ends, and LOCKFILE.sha256 records d4f8f7d8; a test pins that CRLF and LF agree. - The check fails on every run. It only warned outside a release tag, so the snapshot runs passed it with a warning and the release run was the first to stop; --warn-only is gone. - webui-licenses.yml runs the check on every pull request and push (a sparse checkout, no npm), because the Publish runs of pull requests are usually cancelled at the start gate. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01VszvDmRRPP1UcwozsUMY1L
bernardladenthin
had a problem deploying
to
maven-central
October 25, 2026 22:11 — with
GitHub Actions
Failure
bernardladenthin
had a problem deploying
to
startgate
October 25, 2026 22:11 — with
GitHub Actions
Error
bernardladenthin
had a problem deploying
to
maven-central
October 25, 2026 22:11 — with
GitHub Actions
Failure
|
Caution Review failedThe pull request is closed. Finishing Touches
Comment |
|
This branch had an error being deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



The release run of v6.0.0 (40238595195) failed in
Build WebUI assets (shared):Cause: the texts in
llama/legal/natives/webui-npmwere generated from a Windows checkout of llama.cpp (core.autocrlf), soLOCKFILE.sha256recorded the digest of the CRLF lockfile. CI's Linux checkout of the same commit (6050b467, b11887) has LF:git show 6050b467c:tools/ui/package-lock.json | sha256sum=d4f8f7d8…, the CRLF working copy =ca12fa34…. Same lockfile, so the package list and the texts are right; only the recorded digest was wrong. Every snapshot run passed this check with a warning (--warn-onlyoutsiderefs/tags/v*), so the release run was the first to stop. Nothing was published: every native build waits forbuild-webui.Changes
webuilicenses.lockfile_digesthashes the lockfile with LF line ends;LOCKFILE.sha256recordsd4f8f7d8…. New test: CRLF and LF give the same digest (red without the fix).--warn-onlyis removed from the CLI and frombuild-webui.webui-licenses.yml: the same check on every pull request and push -- sparse checkout oftools/uiat the pin, no npm,contents: read. Publish runs of pull requests are usually cancelled at the start gate, sobuild-webuialone would still only catch it in a dispatch.Local: the check against the pinned
tools/uipasses (CRLF working copy, i.e. the case that broke); buildcheck tests 98, the same 3 Windows-local failures as onmain; YAML of both workflows parses; run scripts 135 parse; release gate, templates,check-natives.pyclean. The otherrefs/tags/vconditions inpublish.ymlareUSE_CACHEandcheck-snapshot/check-tagonly.After the merge (owner): nothing of 6.0.0 was published, so move the tag to the merge commit and dispatch again:
🤖 Generated with Claude Code
https://claude.ai/code/session_01VszvDmRRPP1UcwozsUMY1L