Skip to content

Remove the push of the pinned llama.cpp commit to the fork - #569

Merged
bernardladenthin merged 1 commit into
mainfrom
chore/drop-llama-mirror
Oct 25, 2026
Merged

bernardladenthin merged 1 commit into
mainfrom
chore/drop-llama-mirror

Conversation

@bernardladenthin

@bernardladenthin bernardladenthin commented Oct 25, 2026 •

Copy link
Copy Markdown
Owner

mirror-llama-source pushed the pinned upstream commit of every release to bernardladenthin/llama.cpp as jllama/b<nnnn> and needed LLAMA_MIRROR_TOKEN (contents:write on the fork), which was never provisioned -- the first release run would have ended red after publishing. The owner maintains that fork, so the job goes.

  • publish.yml: the job and its mention above archive-llama-source; release-gate-exemptions.txt: its line.
  • .github/mirror-llama-source.sh and .github/buildcheck/tests/test_mirror.py deleted.
  • llama/CMakeLists.txt: JLLAMA_GIT_REPOSITORY stays (default upstream), the comment no longer names the fork.
  • CLAUDE.md, CHANGELOG, TODO: the mirror paragraphs and roadmap item 6's mirror half removed; the signed source archive (archive-llama-source, test-source-archive) is unchanged.

Builds always fetched from upstream (ggerganov/llama.cpp -> ggml-org/llama.cpp) and still do.

Local checks: releasegate 73 jobs, 0 violations; publication wiring 0 problems; run scripts 133, all parse; check-natives.py 0 disagreements; workflow parses as YAML; buildcheck tests 97 (7 fewer, test_mirror.py), the same 3 Windows-local failures as on main.

The workspace policy git-checkout-credentials.md gets the matching edit in its own PR.

🤖 Generated with Claude Code

https://claude.ai/code/session_01VszvDmRRPP1UcwozsUMY1L

Summary by CodeRabbit

  • Changes
    • Releases are no longer automatically mirrored to a separate source repository. The source archive and release publication remain available.
  • Documentation
    • Release documentation now explains the signed source archive, its availability alongside Maven artifacts, and how to rebuild from archived patched source or another clone containing the pinned commit. The documented archive test runs before publication.

mirror-llama-source pushed every release's pinned upstream commit to
bernardladenthin/llama.cpp as jllama/b<nnnn> and needed a write token for
the fork (LLAMA_MIRROR_TOKEN) that was never provisioned. The owner
maintains that fork, so the job, its script and its tests go. Builds always
fetched from upstream and still do; the signed source archive of a release
stays and is what rebuilds a release without upstream.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01VszvDmRRPP1UcwozsUMY1L
@coderabbitai

coderabbitai Bot commented Oct 25, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

Caution

Review failed

The pull request is closed.

Walkthrough

The release workflow no longer pushes the pinned llama.cpp commit to a mirror. The mirror script, its tests, and its release-gate exemption were removed. Documentation and CMake guidance were updated to remove mirror references.

Changes: Release source mirror removal

Layer / File(s) Summary
Remove release mirror operation
.github/mirror-llama-source.sh, .github/buildcheck/tests/test_mirror.py, .github/workflows/publish.yml, .github/release-gate-exemptions.txt
The mirror script, its tests, the workflow job, and the job’s release-gate exemption were removed.
Update source references
CHANGELOG.md, CLAUDE.md, TODO.md, llama/CMakeLists.txt
The source archive, release notes, roadmap, and CMake guidance no longer describe the mirror operation or use the mirror as a fallback source.

Priority: Not assessed

Estimated code review effort: 2 (Simple) | ~10 minutes

Change: Other

Possibly related PRs

Suggested reviewers: claude

Merge Risk: Minimal · up to 5ebdd

Release publication and signed source archives remain available; no issue requiring a fix before merge was identified.

Architecture risk: Low · up to 5ebdd

The change affects 4 systems.

Changed systems: CHANGELOG.md, CLAUDE.md, llama, TODO.md

Architecture concerns
No architecture-level concerns identified.

Review details

Systems and components

  • observed — CHANGELOG.md (service) was modified; 1 changed file maps to changed impact.
  • observed — CLAUDE.md (service) was modified; 1 changed file maps to changed impact.
  • observed — llama (service) was modified; 1 changed file maps to changed impact.
  • observed — TODO.md (service) was modified; 1 changed file maps to changed impact.

Before / after behavior

  • observed — Modified behavior in CHANGELOG.md: The source-archive entry removes the claim that releases are mirrored to bernardladenthin/llama.cpp, including the mirror tag, repository override, and patch-storage details. It retains the archive packaging, signing, attachment, test, and rebuild instructions.
  • observed — Modified behavior in CLAUDE.md: The heading was changed from “Source archive and mirror” to “Source archive.”
  • observed — Modified behavior in CLAUDE.md: The mirror-llama-source subsection was removed, including its post-release mirror push, token requirement, repository selection, credential handling, tests, and policy reference.
  • observed — Modified behavior in TODO.md: Removed the prerequisite to verify mirror credentials and destination access.
Finishing Touches
📝 Generate docstrings
  • Commit to this branch
  • Create a new PR
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Comment @coderabbitai help to get the list of available commands.

@sonarqubecloud

Copy link
Copy Markdown

@bernardladenthin
bernardladenthin merged commit 8c104d4 into main Oct 25, 2026
16 of 88 checks passed
@bernardladenthin
bernardladenthin deleted the chore/drop-llama-mirror branch October 25, 2026 21:40

This branch had an error being deployed

1 failed deployment
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant