[tw-caldav] Fix no priority RFC complaince#156
Open
ferdinandyb wants to merge 1 commit into
Open
Conversation
According to the RFC, the correct value for an undefined priority is 0, not an empty string. The `caldav` package definitely chokes on non-int priorities making it to server-side, when trying to download them. Link: https://datatracker.ietf.org/doc/html/rfc5545#section-3.8.1.9
Collaborator
|
I'm mostly happy with this, but could you move the PR description to the 'Description' section please? Then we can merge. |
Author
done, thank! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
According to the RFC, the correct value for an undefined priority is 0, not an empty string. The
caldavpackage definitely chokes on non-int priorities making it to server-side, when trying to download them.Link: https://datatracker.ietf.org/doc/html/rfc5545#section-3.8.1.9
Fixes # (issue)
Type of change
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide
instructions so we can reproduce. Please also list any relevant details for your
test configuration
nextcloudand the Tasks android app that indeed "no priority" is priority=0, so at least these two applications take the RFC seriouslyChecklist
N/A is striked through
- [ ] I have commented my code, particularly in hard-to-understand areas- [ ] I have made corresponding changes to the documentation- [ ] Any dependent changes have been merged and published in downstream modules