Add paper-aligned two-way HGFD and fluidized-bed validation - #5
Draft
Galigeigei-Z wants to merge 5 commits into
Draft
Add paper-aligned two-way HGFD and fluidized-bed validation#5Galigeigei-Z wants to merge 5 commits into
Galigeigei-Z wants to merge 5 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
P_tot < 0.5, rejected-event velocity handling, and the virtual-displacement momentum budgetPreviews
Field assets: MP4 · ParaView PVD
Why
The public HGD implementation does not contain the 2026 paper's inertial fluid coupling. This PR reconstructs the published equations and validation inputs while keeping the uncoupled defaults unchanged. It also makes the reproducibility boundary explicit: the authors' extended OpenFOAM
pisoFoamparticipant, preCICE configuration, and complete Cases 2--4 inputs have not been published.Two printed details in the paper require a physically consistent interpretation to reproduce Figure 4: the heterarchical coordinate carries mass density
rho_p / M, and the fluid source must be equal and opposite to the particle drag. Both choices and their rationale are documented.Validation
python -m pytest -q test/test_fluid.py test/test_helpers.py test/test_operators.py-- 17 tests passblack --check HGD/fluid.py HGD/motion/hgfd.py scripts/plot_hgfd_case1.py test/test_fluid.pyflake8 HGD/fluid.py HGD/initial.py HGD/motion/hgfd.py scripts/plot_hgfd_case1.py test/test_fluid.pymkdocs build-- succeeds; strict mode only reports pre-existing repository warningsall three full two-way-coupled Case 1 runs complete at 4,000 steps each
terminal-speed differences from the paper HGFD curves: +0.36% (0.5 mm), +0.11% (1.5 mm), +0.07% (2.0 mm)
fluidized-bed example completes 600 deterministic steps
final weighted-continuity residual:
3.14e-12 1/smaximum stochastic transition probability:
0.0128 < 0.5ParaView export: 31 monotonic time steps, with 10 validated particle/fluid cell arrays
generated GIF and H.264 MP4 both pass full-stream decode
Scope
The bundled fluid participant matches the published governing equations and named spatial schemes, but it is not matrix-, PISO-iteration-, or binary-identical to the unpublished OpenFOAM/preCICE participant. The implementation is a 2-D laminar research solver, not a validated industrial bubbling, slugging, turbulent, or reacting fluidized-bed model.