[benbellick]

Which issue does this PR close?

None. This is a fork-only preview for reviewing the combined change.

Rationale for this change

Grouped aggregation currently inserts a hash repartition when grouping by a monotonic transformation of a range-partitioned key, even when the concrete range boundaries keep every resulting group within one input partition.

What changes are included in this PR?

An argument-type-aware, default-deny audit capability enables only timezone-less date_trunc. Concrete boundary analysis establishes group locality, not join co-partitioning. Non-range arguments must be literals; unsupported inputs and evaluation errors fail closed.

Aggregation enforcement and validation share one locality policy, including uncombined partial/final stages and reoptimization of combined aggregates. No transformed range metadata is invented. date_bin, timezone-bearing timestamps, and overlapping bucket boundaries remain denied.

Stronger tests exposed an existing scalar/array discrepancy for negative fractional timestamps. Scalar millisecond/microsecond truncation now uses checked flooring, matching array execution and rejecting underflow.

What is the testing strategy for this PR?

Tests cover capability forwarding, fractional/pre-epoch/calendar boundaries, interspersed nulls, timestamp extremes, and conservative rejection when scalar evaluation fails. A table-driven harness evaluates actual partition arrays across all timestamp units, ASC/DESC and both null placements, checking disjoint images for accepted cases and overlaps for rejected ones. It includes the previously unsafe microsecond split at -999 when truncating to milliseconds.

Optimizer regressions cover validation without aggregate combination, repeated enforcement after combination, and join rejection. SQLLogicTest retains positive aligned date_trunc('hour') and negative day/date_bin cases.

Passed full workspace extended tests, all-target/all-feature strict Clippy, dev/rust_lint.sh, and the targeted SQLLogicTest.

The new range_date_trunc Criterion benchmark uses eight in-memory hourly partitions and eight rows per group. Against fork main at 22651d24c, optimized non-LTO builds of the same benchmark source (20 samples) measured:

Input rows	main	This branch
65,536	1.459 ms	0.923 ms
4,194,304	42.512 ms	27.497 ms

These synthetic aligned-range cases show roughly 35–36% lower execution time, not a general workload claim. Planning and data generation are excluded; results are checked before timing. Measurements used a standalone Cargo driver with SQL/datetime features; the benchmark is also registered for cargo bench -p datafusion --bench range_date_trunc.

Are there any user-facing changes?

Eligible grouped aggregations avoid hash repartitioning. Negative fractional scalar millisecond/microsecond truncation now agrees with array results. Public range-analysis and aggregate-locality APIs are added.

---

Note: This PR was developed with AI assistance. All changes have been reviewed, and I take full responsibility for this contribution.

[github-actions]

Thank you for opening this pull request!

Reviewer note: cargo-semver-checks reported the current version number is not SemVer-compatible with the changes in this pull request (compared against the base branch).

Details

     Cloning apache/main
    Building datafusion v55.1.0 (current)
       Built [  64.202s] (current)
     Parsing datafusion v55.1.0 (current)
      Parsed [   0.035s] (current)
    Building datafusion v55.1.0 (baseline)
       Built [  60.575s] (baseline)
     Parsing datafusion v55.1.0 (baseline)
      Parsed [   0.036s] (baseline)
    Checking datafusion v55.1.0 -> v55.1.0 (no change; assume patch)
     Checked [   0.612s] 223 checks: 223 pass, 31 skip
     Summary no semver update required
    Finished [ 127.552s] datafusion
    Building datafusion-expr v55.1.0 (current)
       Built [  29.779s] (current)
     Parsing datafusion-expr v55.1.0 (current)
      Parsed [   0.087s] (current)
    Building datafusion-expr v55.1.0 (baseline)
       Built [  29.769s] (baseline)
     Parsing datafusion-expr v55.1.0 (baseline)
      Parsed [   0.080s] (baseline)
    Checking datafusion-expr v55.1.0 -> v55.1.0 (no change; assume patch)
     Checked [   1.284s] 223 checks: 223 pass, 31 skip
     Summary no semver update required
    Finished [  62.598s] datafusion-expr
    Building datafusion-expr-common v55.1.0 (current)
       Built [  20.372s] (current)
     Parsing datafusion-expr-common v55.1.0 (current)
      Parsed [   0.019s] (current)
    Building datafusion-expr-common v55.1.0 (baseline)
       Built [  20.200s] (baseline)
     Parsing datafusion-expr-common v55.1.0 (baseline)
      Parsed [   0.020s] (baseline)
    Checking datafusion-expr-common v55.1.0 -> v55.1.0 (no change; assume patch)
     Checked [   0.211s] 223 checks: 223 pass, 31 skip
     Summary no semver update required
    Finished [  43.442s] datafusion-expr-common
    Building datafusion-functions v55.1.0 (current)
       Built [  32.153s] (current)
     Parsing datafusion-functions v55.1.0 (current)
      Parsed [   0.085s] (current)
    Building datafusion-functions v55.1.0 (baseline)
       Built [  32.041s] (baseline)
     Parsing datafusion-functions v55.1.0 (baseline)
      Parsed [   0.086s] (baseline)
    Checking datafusion-functions v55.1.0 -> v55.1.0 (no change; assume patch)
     Checked [   0.506s] 223 checks: 223 pass, 31 skip
     Summary no semver update required
    Finished [  66.345s] datafusion-functions
    Building datafusion-physical-expr v55.1.0 (current)
       Built [  29.761s] (current)
     Parsing datafusion-physical-expr v55.1.0 (current)
      Parsed [   0.050s] (current)
    Building datafusion-physical-expr v55.1.0 (baseline)
       Built [  29.988s] (baseline)
     Parsing datafusion-physical-expr v55.1.0 (baseline)
      Parsed [   0.050s] (baseline)
    Checking datafusion-physical-expr v55.1.0 -> v55.1.0 (no change; assume patch)
     Checked [   0.350s] 223 checks: 222 pass, 1 fail, 0 warn, 31 skip

--- failure enum_variant_added: enum variant added on exhaustive enum ---

Description:
A publicly-visible enum without #[non_exhaustive] has a new variant.
        ref: https://doc.rust-lang.org/cargo/reference/semver.html#enum-variant-new
       impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.50.0/src/lints/enum_variant_added.ron

Failed in:
  variant PartitioningSatisfaction:KeyLocal in /home/runner/work/datafusion/datafusion/datafusion/physical-expr/src/partitioning.rs:560

     Summary semver requires new major version: 1 major and 0 minor checks failed
    Finished [  61.367s] datafusion-physical-expr
    Building datafusion-physical-optimizer v55.1.0 (current)
       Built [  42.110s] (current)
     Parsing datafusion-physical-optimizer v55.1.0 (current)
      Parsed [   0.022s] (current)
    Building datafusion-physical-optimizer v55.1.0 (baseline)
       Built [  42.174s] (baseline)
     Parsing datafusion-physical-optimizer v55.1.0 (baseline)
      Parsed [   0.023s] (baseline)
    Checking datafusion-physical-optimizer v55.1.0 -> v55.1.0 (no change; assume patch)
     Checked [   0.118s] 223 checks: 223 pass, 31 skip
     Summary no semver update required
    Finished [  85.838s] datafusion-physical-optimizer
    Building datafusion-physical-plan v55.1.0 (current)
       Built [  39.259s] (current)
     Parsing datafusion-physical-plan v55.1.0 (current)
      Parsed [   0.161s] (current)
    Building datafusion-physical-plan v55.1.0 (baseline)
       Built [  39.503s] (baseline)
     Parsing datafusion-physical-plan v55.1.0 (baseline)
      Parsed [   0.164s] (baseline)
    Checking datafusion-physical-plan v55.1.0 -> v55.1.0 (no change; assume patch)
     Checked [   0.684s] 223 checks: 223 pass, 31 skip
     Summary no semver update required
    Finished [  81.420s] datafusion-physical-plan
    Building datafusion-sqllogictest v55.1.0 (current)
       Built [ 103.055s] (current)
     Parsing datafusion-sqllogictest v55.1.0 (current)
      Parsed [   0.024s] (current)
    Building datafusion-sqllogictest v55.1.0 (baseline)
       Built [ 103.289s] (baseline)
     Parsing datafusion-sqllogictest v55.1.0 (baseline)
      Parsed [   0.023s] (baseline)
    Checking datafusion-sqllogictest v55.1.0 -> v55.1.0 (no change; assume patch)
     Checked [   0.097s] 223 checks: 223 pass, 31 skip
     Summary no semver update required
    Finished [ 209.930s] datafusion-sqllogictest

[benbellick]

Superseded by the stacked fork-only previews in #3 and #4.