Tidy CI caching and dead workflow config - #2025
Merged
Merged
Conversation
- Exclude node_modules/.astro/chrome from the Astro build cache (it has its own cache) so ~150MB of Chromium isn't re-saved with every build-cache entry - Give the e2e build job the same astro-pdf Chromium cache as deploy - Don't cancel an in-progress deploy; queued runs are still superseded - Drop FORCE_JAVASCRIPT_ACTIONS_TO_NODE24; every pinned action already runs on node24 - Remove the nonexistent master branch trigger and js/** path filters - links.yml: drop the schedule-only issue step (no schedule exists) and its issues: write permission; don't persist checkout credentials Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CI cleanup from a general audit.
node_modules/.astro) contained the Chromium cache (node_modules/.astro/chrome), so every new build-cache entry re-saved about 150 MB of browser. That path is now excluded; Chromium keeps its own lockfile-keyed cache./resume.pdf, so it needs Chromium too. Until now it only got Chromium by accident, through the shared Astro cache key. It now has the same explicit cache as deploy.cancel-in-progress: false, so a new push can no longer killwrangler deploymid-upload. GitHub still replaces a queued run with the newest one.FORCE_JAVASCRIPT_ACTIONS_TO_NODE24removed. I checked each pinned action'saction.yml: cache, checkout, and setup-node all declarenode24already.mastertrigger (no such branch) and thejs/**path filters (no such directory).links.yml. The issue step only ran onschedule, and the workflow has no schedule. Removed it andissues: write, and setpersist-credentials: false. The workflow is still disabled; I didn't delete it because it also validates HTML.Verification
actionlintandyamllintpass.mainalready has.🤖 Generated with Claude Code