Give utf_transcoding_error and to_utf_view_error_kind unspecified underlying types#225
Merged
Conversation
…erlying types Following the precedent of memory_order, launch, and assertion_kind. Fixing the underlying type (to int or bool) is an unnecessary constraint; an unspecified underlying type gives implementations freedom to choose a type suited to their layout and ABI needs. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
ednolan
changed the title
|
coverage: 99.744%. remained the same — enolan_underlyingtype1 into main |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Following the precedent of memory_order, launch, and assertion_kind. Fixing the underlying type (to int or bool) is an unnecessary constraint; an unspecified underlying type gives implementations freedom to choose a type suited to their layout and ABI needs.