Repository navigation
De-duplicate Application URL and author options during project conversion - #3146
Closed
abdul-karim-mia wants to merge 1 commit into
Closed
abdul-karim-mia wants to merge 1 commit into
abdul-karim-mia wants to merge 1 commit into
Conversation
Signed-off-by: Abdul karim mia <97598943+abdul-karim-mia@users.noreply.github.com>
freakboy3742
left a comment
Member
There was a problem hiding this comment.
Thanks for the PR; however, in this case, I think the solution is what was hinted at in this comment - switch to a PEP 621 representation for authors. We have a PR in flight for that at present (see #3131), so it should be resolved in the near future.
Apologies for the confusion.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #2120
Description
When converting a project using
briefcase convert, ifpyproject.tomldefines identical URLs across multiple metadata fields (e.g., bothHomepageandRepositorypointing to the same repository URL),input_urlpreviously presented duplicate options in the selection prompt. Similarly, multiple author entries with identical names produced duplicate choices and redundant joined strings (Name & Name).This PR:
optionsextracted fromself.pep621_data.get("urls", {}).values()while preserving insertion order usingdict.fromkeys.self.pep621_data.get("authors", [])usingdict.fromkeys.test_input_url.pyandtest_input_author.pyverifying that duplicate URLs and authors are filtered out from selection questions.changes/2120.bugfix.md.PR Checklist: