Repository navigation
Respect DESKTOP_SHORTCUT property during silent installs - #132
Merged
Merged
Conversation
freakboy3742
approved these changes
Oct 18, 2026
freakboy3742
left a comment
Member
There was a problem hiding this comment.
Good catch - thanks for the contribution! I'll merge this back to the app template shortly.
2 of 3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Running a silent install, the DESKTOP_SHORTCUT property is ignored and a desktop shortcut is always created. For example when passing
DESKTOP_SHORTCUT=""(msiexec /i app.msi /qn DESKTOP_SHORTCUT="") a shortcut is created anyway.DesktopShortcutFeaturepreviously defaulted toLevel="1"and relied on dialog<Publish>events to disable the feature. Since silent installations (/qn) bypass theInstallUISequence, those dialog events do not run and the feature remains atLevel="1".This change
DesktopShortcutFeaturetoLevel="0"<Level Condition="DESKTOP_SHORTCUT = "1" OR UILevel >= 5" Value="1" />so the feature is enabled in silent installs only whenDESKTOP_SHORTCUT="1", while remaining enabled at the start of interactive installs so they work as before.Testing
Tested using a packaged test MSI configured with
create_desktop_shortcut = true:DESKTOP_SHORTCUT=""(msiexec /i app.msi /qn DESKTOP_SHORTCUT=""),msiexec /i app.msi /qn),Note: This is also the case in
beeware/briefcase-windows-app-template. If you feel that these changes are reasonable I'm happy to open a matching PR there.Refs ankitects/anki#5671
PR Checklist:
Assisted-by: Gemini 4 Argon