Skip to content

34467 Colin API - snapshot appt dt fix - #4748

Open
kialj876 wants to merge 1 commit into
bcgov:mainfrom
kialj876:34467-colin-api-snapshot-director-appt-dt-fix
Open

34467 Colin API - snapshot appt dt fix#4748
kialj876 wants to merge 1 commit into
bcgov:mainfrom
kialj876:34467-colin-api-snapshot-director-appt-dt-fix

Conversation

@kialj876

@kialj876 kialj876 commented Aug 28, 2026

Copy link
Copy Markdown
Collaborator

Issue #: /bcgov/entity#34467

Description of changes:

  • fixes director appointment date formatting from cases that default from the business founding date

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the lear license (Apache 2.0).

Signed-off-by: Kial Jinnah <kialj876@gmail.com>
@kialj876 kialj876 self-assigned this Aug 28, 2026
@kialj876
kialj876 requested review from meawong and mruff-aeq August 28, 2026 16:21
@sonarqubecloud

Copy link
Copy Markdown

@codecov

codecov Bot commented Aug 28, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 33.89%. Comparing base (d995156) to head (c7e9937).
⚠️ Report is 696 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4748      +/-   ##
==========================================
+ Coverage   29.66%   33.89%   +4.23%     
==========================================
  Files          39       40       +1     
  Lines        3486     3711     +225     
==========================================
+ Hits         1034     1258     +224     
- Misses       2452     2453       +1     
Flag Coverage Δ
colinapi 33.89% <100.00%> (+4.23%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...olin-api/src/colin_api/models/business_snapshot.py 93.02% <100.00%> (ø)
colin-api/src/colin_api/version.py 100.00% <100.00%> (ø)

... and 6 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants