fix(examiner-ui): restore application approval conditions

[jimmypalelil]

Issue

JIRA: https://hous-hpb.atlassian.net/browse/REGBACKLOG-9

Summary

• restore the approval condition selector for application approvals
• add DecisionPanel regression coverage for approval visibility, assignment gating, and the approval email lock

[Copilot]

Pull request overview

Restores approval-condition controls in the examiner decision panel and adds regression coverage.

Changes:

• Shows approval conditions for assigned application approvals.
• Tests visibility, assignment gating, and email locking.
• Identified that selected application conditions are not persisted.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File	Description
DecisionPanel.vue	Restores application approval conditions.
decision-panel.spec.ts	Adds DecisionPanel regression tests.

---

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

[Copilot]

Pull request overview

Copilot reviewed 9 out of 9 changed files in this pull request and generated 3 comments.

[Copilot]

Pull request overview

Copilot reviewed 11 out of 11 changed files in this pull request and generated 1 comment.

[Copilot]

Pull request overview

Copilot reviewed 11 out of 11 changed files in this pull request and generated 1 comment.

[Copilot]

Pull request overview

Copilot reviewed 11 out of 11 changed files in this pull request and generated 1 comment.

[Copilot]

Pull request overview

Copilot reviewed 11 out of 11 changed files in this pull request and generated no new comments.

Suppressed comments (1)

Previously missed (1) — in code that hasn't changed since the last review.

strr-examiner-web/app/components/DecisionPanel.vue:266

• Provisional-review applications still cannot reach this restored selector. useExaminerDecision.ts:36-38 makes showDecisionPanel false whenever an application has a registration number, while models/application.py:646-649 adds that number for applications backed by the existing registration used during provisional approval. The outer v-if="showDecisionPanel" therefore removes this component, and the legacy page action calls provisionallyApproveApplication without conditions. Relax the panel gate for actionable provisional approvals and route those approvals through this panel; the new tests currently hard-code showDecisionPanel to true, so they mask this path.

            v-if="isApproveDecisionSelected && isAssignedToUser"

[jimmypalelil]

Addressed the suppressed Copilot finding from review 5047431894 in commit e59721f8.

• Provisional-review applications with an existing registration now show the DecisionPanel when PROVISIONAL_APPROVE is available.
• The bottom ActionButtons are also kept visible so the approval selected in the panel can be submitted through the conditions-aware path.
• Existing predefined, custom, and minimum-booking-day conditions are loaded before approval.
• Added coverage for provisional application panel visibility and existing-condition loading.

Validation: 24 focused frontend tests passed and frontend lint passed with only two pre-existing warnings. vue-tsc was unavailable in the local project dependencies.

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[Copilot]

Pull request overview

Copilot reviewed 14 out of 14 changed files in this pull request and generated no new comments.