Skip to content

Handle PostgreSQL schema creation without workaround first #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
adelinn merged 2 commits into from
Sep 1, 2026
Merged

Handle PostgreSQL schema creation without workaround first #2

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
83a9c07
Add transaction handling for PostgreSQL schema creation
adelinn Sep 1, 2026
28c5fd0
Better handle fallback
adelinn Sep 1, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 21 additions & 0 deletions postgresql/resource_postgresql_schema.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -118,6 +118,27 @@ func resourcePostgreSQLSchema() *schema.Resource {

func resourcePostgreSQLSchemaCreate(db *DBConnection, d *schema.ResourceData) error {
database := getDatabase(d, db.client.databaseName)

// Try without roles workaround first
txn1, err := startTransaction(db.client, database)
if err != nil {
return err
}
attemptErr := createSchema(db, txn1, d)
if attemptErr == nil {
if err := txn1.Commit(); err == nil {
// Creating worked so we return here
d.SetId(generateSchemaID(d, database))

return resourcePostgreSQLSchemaReadImpl(db, d)
}
}

if err := txn1.Rollback(); err != nil && err != sql.ErrTxDone {
return fmt.Errorf("error rolling back initial schema transaction: %w", err)
}

// Creating without workaround failed so we fallback to use it.
txn, err := startTransaction(db.client, database)
if err != nil {
return err
Expand Down
Loading