Chore/dependency and typo cleanup - #511
Merged
Merged
Conversation
…nts list The subtitle language set is a plain map, the isilon export workflow id uses uuid like the rest of the trigger UI, and the leftover spew debug dumps are gone, so go-spew is only testify's indirect dependency now. Renamed EmtpySRTFile, PlacholderTplData, SubSteams and BmmTargetEnvionment. SubStreams has no JSON tag but nothing reads it, and the BMM field already had the correct tag, so stored histories decode unchanged. potential_improvements.md is revalidated against the code: twelve fixed items removed, stale references corrected. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
ci.yml gains a tidy job (go mod tidy -diff) and a govulncheck job. .dockerignore keeps the build context to what go build needs, since every Dockerfile does COPY . .. Update potential_improvements.md. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Covers the enum stragglers from potential_improvements.md: watch-folder names, Vidispine job states and shape tags, Directus short status / media item type / image style, and VBExportParams.Destinations. A new internal/enumjson helper encodes every member as its bare string, so workflow payloads look exactly as they did with plain string fields and existing histories replay without migration. Values this codebase produces (watch folders, VB destinations) reject unknown strings; values external systems report (Vidispine, Directus) keep them so an unlisted state still decodes and compares unequal to every named member. The file watcher now rejects an unconfigured transcode folder before starting a workflow instead of letting the workflow fail and move the file to the error folder. The JOB_FAILED and VS_SHAPE_TAG_NOT_FOUND error types are named constants. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.