Repository navigation
Pin the dialer and IR queue subtree restart and stop behaviour - #46
Merged
Merged
Conversation
Three behaviours from the subtree change had no test that failed when broken: - The dialer stops before its dial task: the shutdown test now traces the dialer's mailbox and refutes the task's DOWN, instead of hoping a log line shows the wrong order under load. - A dialer crash restarts the listener: a target client's socket closes. - A crash of the IR queue kills the transmit it started, so a new queue never overlaps it. Each fails when its subtree is set back to the other order or strategy. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
There was a problem hiding this comment.
🔵 Needs a closer look
The scheduler-sensitive trace assertion needs runtime verification, which was unavailable in the review environment.
No open issues 🎉
What changed in this PR
This test-only PR strengthens coverage of dialer and infrared queue lifecycle behavior.
Changes:
- Trace dialer messages to check shutdown ordering.
- Verify a dialer crash closes a connected client’s socket.
- Verify an infrared queue crash stops its transmit task.
| File | Description |
|---|---|
| test/espex/dialer_test.exs | Strengthens shutdown-order and crash-cleanup coverage. |
| test/espex/api_1_18_test.exs | Adds transmit-task cleanup coverage after a queue crash. |
Review effort: Balanced
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
:DOWN, so it fails every time the dialer is ordered before its supervisors (it previously caught that only under load)🤖 Generated with Claude Code