Repository navigation
Avoid Metal resource output collisions in XCFrameworks - #3109
Merged
adincebic merged 1 commit intoOct 22, 2026
Merged
Conversation
vakhidbetrakhmadov
requested review from
aaronsky,
adincebic,
brentleyjones,
keith and
luispadron
as code owners
October 22, 2026 00:53
Honor the resource output discriminator when declaring Metal libraries and scope AIR intermediates to their owning library. This prevents device and simulator compilation from declaring the same outputs when an XCFramework contains Metal resources. Add a regression that packages compiled shader libraries in both device and simulator framework slices.
vakhidbetrakhmadov
force-pushed
the
fix-xcframework-metal-outputs
branch
from
October 22, 2026 01:05
eed947d to
5a8f127
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
An
apple_static_xcframeworkcontaining Metal resources for both iOS device and simulator slices fails with conflictingMetalCompileactions because the slices declare the same intermediate output paths.Use the resource output discriminator when declaring
.metalliboutputs and declare.airintermediates alongside their owning Metal library.Fixes #3108.