Repository navigation
Add swift_module support to apple_resource_bundle - #3107
Open
vakhidbetrakhmadov wants to merge 1 commit into
Open
vakhidbetrakhmadov wants to merge 1 commit into
vakhidbetrakhmadov wants to merge 1 commit into
Conversation
vakhidbetrakhmadov
requested review from
aaronsky,
adincebic,
brentleyjones,
keith and
luispadron
as code owners
October 21, 2026 19:19
| owner = owner, | ||
| parent_dir_param = bundle_name, | ||
| resources = infoplists, | ||
| **bucketize_args |
Contributor
Author
There was a problem hiding this comment.
bucketize_args was previously empty for resource bundles. It now contains swift_module, which bucketize_typed_data doesn’t accept, so forwarding it here would cause an analysis error.
vakhidbetrakhmadov
force-pushed
the
fix-resource-bundle-swift-module
branch
from
October 21, 2026 21:17
3224593 to
e991613
Compare
Allow resource bundles to specify the Swift module used to compile Core Data models and Interface Builder resources instead of inheriting the consuming bundle module. Keep Info.plist bucketing independent of the Swift module. Add app, unit-test, and compiled-model regressions. Fixes bazelbuild#2606.
vakhidbetrakhmadov
force-pushed
the
fix-resource-bundle-swift-module
branch
from
October 22, 2026 11:40
5bb39da to
a0c0510
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allow resource bundles to specify the Swift module used to compile Core Data models and Interface Builder resources instead of inheriting the consuming bundle module.
Add app and unit-test regressions for Core Data, storyboard, and XIB compiler module arguments, plus a compiled-model regression.
Validation: all seven regressions pass with Bazel 9.3.1 and Xcode 27.1. All four storyboard/XIB checks fail when resource bundle module propagation is removed.
Fixes #2606