Repository navigation
Skip cloning the repo in the first step of Google Bazel Presubmit, take 2 - #2938
Merged
Merged
Conversation
Wyverald
requested review from
SalmaSamy,
meteorcloudy and
ted-xie
and removed request for
a team and
SalmaSamy
October 9, 2026 13:21
Terraform Plan for
|
ted-xie
approved these changes
Oct 9, 2026
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reland of #2930
Original change description
By default, all "command" steps in a Buildkite job will clone the git repo associated with the Buildkite pipeline. We can skip this checkout by setting
checkout: skip: truein the step config.We do this for the first step of Google Bazel Presubmit, which doesn't actually need more than the presubmit.yml file (except for checking if modified files include sensitive yaml files -- which we now disable with an environment variable). To get the presubmit.yml, we directly fetch it from googlesource, though it's base64-encoded -- so we decode it.
Difference from #2930
It turns out
checkout: skip: trueis implemented as setting the environment variableBUILDKITE_SKIP_CHECKOUT, which propagates to all printed steps. So the fix is simply to print all steps in bazelci.py withcheckout: skip: falseby default. Conveniently, we can also skip the checkout for the very last step ("print shard summary").Also, the printed steps inherit the
--file_configflag from the first step, so we actually have to use.bazelci/presubmit.ymlinstead of justpresubmit.yml.Tested
bazel-testing run: https://buildkite.com/bazel-testing/bazel-bazel-github-presubmit/builds/394/list?sid=01a120c8-0420-4491-8245-685cfdbbcadf&tab=output