Support multiple FSEvents watch roots#835
Open
longlho wants to merge 1 commit into
Open
Conversation
longlho
marked this pull request as ready for review
July 17, 2026 20:32
Contributor
Author
|
gentle ping @achew22 😄 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
On macOS, iBazel collapsed every watched directory into one FSEvents root. When a workspace and a local or overridden repository lived under different top-level directories, no common root existed, so updating the watch list failed.
Group watched directories by top-level tree and compute one recursive watch root per group. This preserves the existing protection against FSEvents' 4,096-path limit without falling back to watching
/.Add a Darwin E2E with the Bazel workspace under
/privateand an overridden repository under/Users; changing the external source must trigger another run.Fixes #819.
Test
bazel test //... --test_output=errors