Skip to content

Cancel superseded PR test runs, run the suite daily, and cache the race build #564

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
robzolkos merged 1 commit into from
Oct 12, 2026
Merged

Cancel superseded PR test runs, run the suite daily, and cache the race build #564

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
36 changes: 34 additions & 2 deletions .github/workflows/test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,20 @@ on:
# must still get the full gate before they reach main.
pull_request:
workflow_dispatch:
# A daily full run on main. govulncheck reads a database that changes
# without any commit here: an advisory published against a module or Go
# release we already ship turns main red the next morning instead of at the
# next push or the next release dry run.
schedule:
- cron: '23 6 * * *'

# A new push to a PR supersedes the run on its old head, so that run is
# cancelled. Every other event gets a group of its own (the run id): a merge to
# main, the schedule and a manual dispatch always run in full and are never
# queued behind, or replaced by, another run.
concurrency:
group: test-${{ github.event_name == 'pull_request' && format('pr-{0}', github.event.pull_request.number) || github.run_id }}
cancel-in-progress: ${{ github.event_name == 'pull_request' }}

permissions: {}

Expand Down Expand Up @@ -136,7 +150,21 @@ jobs:
with:
go-version-file: go.mod

# setup-go keeps one build cache for every job, saved by whichever job
# finishes first, and that cache never holds race-instrumented objects:
# this job used to spend ~40s of its ~100s recompiling every dependency
# with -race. It now has a build cache of its own, keyed like setup-go's
# (go.mod carries the toolchain line, go.sum the dependency set), so a
# run recompiles only what changed since that cache was saved.
- name: Cache race build
uses: actions/cache@55cc8345863c7cc4c66a329aec7e433d2d1c52a9 # v6.1.0
with:
path: ${{ runner.temp }}/go-build-race
key: go-build-race-${{ runner.os }}-${{ runner.arch }}-${{ hashFiles('go.mod', 'go.sum') }}

- name: Run tests with race detector
env:
GOCACHE: ${{ runner.temp }}/go-build-race
run: go test -race -count=1 ./...

e2e:
Expand Down Expand Up @@ -358,8 +386,12 @@ jobs:
fetch-depth: 2
persist-credentials: false

# The filter narrows a PR or a push to what it changed. The schedule and
# a manual dispatch have no change set to narrow by, so the step is
# skipped and the flake is built in full.
- name: Check for flake-relevant changes
id: filter
if: github.event_name == 'pull_request' || github.event_name == 'push'
uses: dorny/paths-filter@ceb8a2b8f2d89434be7ff52d3de7ec3738c5cc9d # v4.0.3
with:
filters: |
Expand All @@ -377,11 +409,11 @@ jobs:
- '.github/workflows/test.yml'

- name: Install Nix
if: steps.filter.outputs.nix == 'true'
if: steps.filter.outputs.nix == 'true' || steps.filter.conclusion == 'skipped'
uses: cachix/install-nix-action@13d8dd58da0234aa297dedd986986ccb8e7f3e24 # v31.11.1

- name: Build the flake
if: steps.filter.outputs.nix == 'true'
if: steps.filter.outputs.nix == 'true' || steps.filter.conclusion == 'skipped'
run: scripts/nix-build-check.sh

cli-surface:
Expand Down
Loading