Repository navigation
Say that saved attachments are marked, and where that is best effort - #561
Conversation
hey attachment save's help and docs/cli.md now say every saved file is marked as downloaded from the internet, that a macOS save that can't be marked fails, and that the Windows mark is written only where the drive can hold it. docs/tui.md stops promising the Windows mark everywhere and says a zip-based document can still open on Linux, in an archive manager at worst. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
There was a problem hiding this comment.
🟡 Changes recommended
The documentation incorrectly claims all saved attachments are marked, although marking is a no-op outside macOS and Windows.
3 open findings
What changed in this PR
Clarifies attachment download-origin marking and Linux handling of ZIP-based documents.
Changes:
- Expands
attachment savehelp and agent notes. - Updates CLI and TUI documentation with platform-specific behavior.
[!TIP]
If you aren't ready for review, convert to a draft PR.
Click "Convert to draft" or rungh pr ready --undo.
Click "Ready for review" or rungh pr readyto reengage.
| File | Description |
|---|---|
internal/cmd/attachments_save.go |
Expands save-command help. |
docs/cli.md |
Documents download-origin marking. |
docs/tui.md |
Clarifies marking and ZIP-document handling. |
🧠 Review effort: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
There was a problem hiding this comment.
All reported issues were addressed across 3 files
Reply with feedback, questions, or to request a fix.
View guided diff | Turn on auto-fix | Re-trigger cubic
Linux and the other systems keep no record of where a file came from, so nothing marks a file saved there; the help text and docs said every saved file was marked. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Follow-up to #560, from its review threads:
hey attachment savehelp anddocs/cli.mdnow say every saved file is marked as downloaded from the internet, that a macOS save that can't be marked fails, and that the Windows mark is written only where the drive can hold it.docs/tui.mdstops promising the Windows mark everywhere, and says a zip-based document can still open on Linux, in an archive manager at worst.Docs and help text only; no behavior change.
Summary by cubic
Clarifies that saved attachments are marked as downloaded from the internet on macOS and Windows, and where that marking is best effort, following up on review threads from #560.
hey attachment savehelp anddocs/cli.mdnow say a macOS save that can't be marked fails, and the Windows mark is written only where the drive can hold it; other systems keep no mark.docs/tui.mdstops promising the Windows mark everywhere and notes that a zip-based document can still open on Linux, in an archive manager at worst.Docs and help text only; no behavior change.
Written for commit 049ef90. Summary will update on new commits.