Repository navigation
Register #925 so main's known-defect gate goes green again - #927
Conversation
#922 landed a comment reading "tracked in #925" without the registry row that sentence requires, so check-known-defect-issues-open has been failing on main since that merge. The row was written during the review but the PR merged before it was pushed. The gate behaved exactly as designed: a prose promise that an issue owns a gap now fails closed until it has a row that will keep failing if the issue closes while the gap does not.
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
🟢 Approved
The entry matches the tracked prose claim, its mention count, and the currently open issue.
Pull request overview
Registers issue #925 so the known-defect gate recognizes the existing tracking claim.
Changes:
- Adds the #925 registry entry with the correct source file and mention count.
[!TIP]
If you aren't ready for review, convert to a draft PR.
Click "Convert to draft" or rungh pr ready --undo.
Click "Ready for review" or rungh pr readyto reengage.
File summaries
| File | Description |
|---|---|
spec/tracking-issues.yml |
Registers the #925 tracking claim. |
Review details
- Files reviewed: 1/1 changed files
- Comments generated: 0
- Review effort level: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
What broke
check-known-defect-issues-openhas been failing onmainsince #922 merged.#922's final state added a comment to
scripts/check-required-tags.rbreading "…deliberately not addressed here, and tracked in #925." That is the canonical grammar the gate sweeps for, so it requires a matching row inspec/tracking-issues.yml. The row was written and verified during review, but #922 merged at 07:17:48Z on head44e0bef— before that commit was pushed — so the sentence shipped without it.On
mainas merged:The fix
One registry row, which is what the sentence always needed.
ruby scripts/check-known-defect-issues-openpasses on this branch and fails onmainwithout it — both verified locally rather than inferred.Worth saying plainly
The gate did its job. A sentence promising that an issue owns a gap is a claim that rots silently when the issue closes and the gap does not — the reason this registry exists, per its own header and the #588 history. It failed closed on a real, unregistered promise. The bug is that the promise and its row were split across a merge boundary, not anything about the check.
#925 is open and tracks the actual gap: the six per-language generators each iterate a five-verb list, so an operation on any verb outside
get/post/put/patch/deletewould be dropped from the generated services entirely rather than merely shipping untagged.Summary by cubic
Registers issue #925 in
spec/tracking-issues.ymlso the known-defect gate onmaingoes green again. The gate was failing becausescripts/check-required-tags.rbreferences #925 as a tracking issue without the matching registry entry. Adding the entry passes the gate and ensures it will fail again if #925 closes while the underlying defect remains.Written for commit 467e63f. Summary will update on new commits.