Chore/refactor with enhancements by basebandit · Pull Request #37 · basebandit/zeus

basebandit · 2026-02-04T21:18:48Z

No description provided.

…lishing

Copilot

Pull request overview

Refactors the staging Terraform stack to use reusable VPC/EKS modules and adds repo-wide automation improvements (pre-commit, lint/test workflows, and release tooling), along with minor Go formatting/tidy updates for the Inventory service.

Changes:

Replace inline staging VPC/EKS resources with infrastructure/modules/vpc and infrastructure/modules/eks wrappers around terraform-aws-modules/*.
Add Inventory CI (lint/test/release), Go lint config, and a generated changelog workflow.
Update Orders workflows (tag naming convention, pre-release automation, and CI improvements) and expand pre-commit hooks.

Reviewed changes

Copilot reviewed 34 out of 40 changed files in this pull request and generated 10 comments.

Show a summary per file

File	Description
infrastructure/staging/vpc.tf	Switch staging VPC to use the new VPC module with EKS subnet tags and NAT config.
infrastructure/staging/subnets.tf	Removed (subnets now created by VPC module).
infrastructure/staging/routes.tf	Removed (route tables now managed by VPC module).
infrastructure/staging/nat.tf	Removed (NAT gateway/EIP now managed by VPC module).
infrastructure/staging/igw.tf	Removed (IGW now managed by VPC module).
infrastructure/staging/eks.tf	Switch staging EKS to use the new EKS module and managed node groups map.
infrastructure/staging/nodes.tf	Removed (node groups now managed by EKS module).
infrastructure/staging/providers.tf	Update Helm provider config to use module outputs + AWS exec auth; bump AWS provider constraint.
infrastructure/staging/pod-identity-addon.tf	Point addon to `module.eks.cluster_name`.
infrastructure/staging/outputs.tf	Rewire outputs from raw resources to module outputs; add OIDC provider output; drop some removed outputs.
infrastructure/staging/locals.tf	Adjust cluster naming local (no longer appends “-cluster”).
infrastructure/staging/argocd.tf	Helm releases now depend on `module.eks` instead of a node group resource.
infrastructure/staging/argocd-image-updater.tf	Update IAM role naming and pod identity association to use module cluster name.
infrastructure/staging/argocd-external-secrets-provider.tf	Update cluster references to module outputs; keep bootstrap `kubectl` null_resources.
infrastructure/modules/vpc/versions.tf	New module provider/version constraints for VPC wrapper.
infrastructure/modules/vpc/variables.tf	New VPC wrapper inputs (CIDR/subnets/NAT/DNS/tags, etc.).
infrastructure/modules/vpc/main.tf	Wrap `terraform-aws-modules/vpc/aws` v6.6.0 with standardized tagging.
infrastructure/modules/vpc/outputs.tf	Expose common VPC outputs from the wrapped module.
infrastructure/modules/vpc/README.md	Document VPC wrapper usage and inputs/outputs.
infrastructure/modules/eks/versions.tf	New module provider/version constraints for EKS wrapper.
infrastructure/modules/eks/variables.tf	New EKS wrapper inputs (name/VPC/subnets/node groups/tags/log retention).
infrastructure/modules/eks/main.tf	Wrap `terraform-aws-modules/eks/aws` v21.14.0 with logging/KMS/IRSA defaults.
infrastructure/modules/eks/outputs.tf	Expose common EKS outputs from the wrapped module.
infrastructure/modules/eks/README.md	Document EKS wrapper usage and inputs/outputs.
apps/inventory/internal/service/inventory_service.go	Formatting-only alignment of exported error vars.
apps/inventory/internal/models/models.go	Formatting-only alignment of struct fields/tags.
apps/inventory/internal/handler/inventory_handler.go	Fix gofmt issue in `AddStockRequest` declaration.
apps/inventory/internal/events/events.go	Formatting-only alignment of event structs.
apps/inventory/internal/events/event_handler.go	Formatting-only alignment in low-stock alert event initialization.
apps/inventory/go.mod	Reorganize dependencies: promote key deps to direct requirements, tidy indirects.
apps/inventory/go.sum	Updated sums consistent with module tidy/dependency graph changes.
apps/inventory/CHANGELOG.md	Add initial changelog scaffold for git-chglog-based release process.
apps/inventory/.golangci.yml	Add golangci-lint configuration for Inventory service.
.pre-commit-config.yaml	Add Go (Inventory) and TS (Orders) hooks; expand shared checks; exclude node_modules.
.github/workflows/orders-release.yml	Change tag format to `orders/v..*`, update version extraction, bump GH release action.
.github/workflows/orders-pre-release.yml	Add workflow to prepare Orders release (version bump + changelog + PR).
.github/workflows/orders-lint.yml	Tighten PR event types, add TypeScript typecheck, soften Codecov failure behavior.
.github/workflows/inventory-release.yml	Add Inventory release workflow for `inventory/v..*` tags (test/build/push/release).
.github/workflows/inventory-pre-release.yml	Add Inventory pre-release workflow (git-chglog + branch + PR).
.github/workflows/inventory-lint.yml	Add Inventory CI workflow (tidy/format/lint/vulncheck/tests + coverage upload).

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

… usage

Copilot · 2026-02-09T05:43:03Z

@basebandit I've opened a new pull request, #38, to work on those changes. Once the pull request is ready, I'll request review from you.

Copilot · 2026-02-09T05:43:12Z

@basebandit I've opened a new pull request, #39, to work on those changes. Once the pull request is ready, I'll request review from you.

Copilot · 2026-02-09T05:43:18Z

@basebandit I've opened a new pull request, #40, to work on those changes. Once the pull request is ready, I'll request review from you.

Copilot · 2026-02-09T05:43:33Z

@basebandit I've opened a new pull request, #41, to work on those changes. Once the pull request is ready, I'll request review from you.

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Copilot · 2026-02-09T05:56:26Z

@basebandit I've opened a new pull request, #42, to work on those changes. Once the pull request is ready, I'll request review from you.

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

* Initial plan * feat(eks): add missing input variables to align with README documentation Co-authored-by: basebandit <8973567+basebandit@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: basebandit <8973567+basebandit@users.noreply.github.com>

* Initial plan * feat(eks): make kubernetes_version configurable via variable Co-authored-by: basebandit <8973567+basebandit@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: basebandit <8973567+basebandit@users.noreply.github.com>

* Initial plan * feat(eks): make endpoint access configurable via module inputs - Add endpoint_public_access and endpoint_private_access variables - Add cluster_version variable for Kubernetes version - Update main.tf to use variables instead of hardcoded values - Set secure defaults (private-only access) for backward compatibility - Update README to reflect correct variable names and defaults Co-authored-by: basebandit <8973567+basebandit@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: basebandit <8973567+basebandit@users.noreply.github.com>

* Initial plan * fix(terraform): add guards to NAT gateway outputs for resilience Co-authored-by: basebandit <8973567+basebandit@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: basebandit <8973567+basebandit@users.noreply.github.com>

* Initial plan * fix(terraform): guard NAT gateway outputs with try() for when NAT is disabled Co-authored-by: basebandit <8973567+basebandit@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: basebandit <8973567+basebandit@users.noreply.github.com>

basebandit added 7 commits February 5, 2026 00:16

ci(inventory): add lint, release, and pre-release workflows

9991318

ci(orders): add pre-release workflow and enhance existing workflows

f0afd68

chore: add Go and TypeScript pre-commit hooks for inventory and orders

c75ae00

refactor(terraform): migrate staging VPC and EKS to reusable modules

6c06640

fix: tidy go modules

a7fcc7b

fix: format to evade lint warning in ci

883dd3c

fix(inventory): upgrade golangci-lint to v1.64.2 for Go 1.24 support

6c09350

basebandit force-pushed the chore/refactor-with-enhancements branch from c01ccf0 to 6c09350 Compare February 9, 2026 05:28

basebandit requested a review from Copilot February 9, 2026 05:30

Copilot started reviewing on behalf of basebandit February 9, 2026 05:31 View session

basebandit added 2 commits February 9, 2026 08:34

fix(inventory): add error handling for message ack/nack and event pub…

293672a

…lishing

refactor(inventory): improve code quality and fix gocritic issues

7e05fea

Copilot AI reviewed Feb 9, 2026

View reviewed changes

basebandit added 3 commits February 9, 2026 08:38

refactor(inventory): optimize struct field alignment to reduce memory…

f4b47a8

… usage

fix(inventory): resolve variable shadowing issues

4a3e0af

test(inventory): remove unused field assignments and preallocate slice

d5c3d6d

Copilot AI mentioned this pull request Feb 9, 2026

feat(eks): expose configurable variables documented in README #38

Merged

Copilot AI mentioned this pull request Feb 9, 2026

Make EKS Kubernetes version configurable via module variable #39

Merged

This was referenced Feb 9, 2026

Guard NAT gateway outputs against empty lists #40

Merged

fix(terraform): guard NAT gateway outputs against disabled NAT #41

Merged

basebandit and others added 2 commits February 9, 2026 08:43

Update infrastructure/modules/vpc/README.md

a2c2a6b

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Update infrastructure/modules/eks/main.tf

95bbf57

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Copilot AI mentioned this pull request Feb 9, 2026

Make EKS endpoint access configurable via module inputs #42

Merged

basebandit and others added 2 commits February 9, 2026 08:56

Update infrastructure/modules/eks/variables.tf

daab0be

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Update .github/workflows/inventory-pre-release.yml

e815229

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Copilot AI and others added 13 commits February 9, 2026 08:58

lint(inventory): fix linting format warnings

ba04864

fix(inventory): resolve all remaining linting issues

42ed965

chore: update golangci-lint to v1.64.2 in pre-commit hooks

ab87cab

fix(pre-commit): improve hook configuration for better compatibility

cf35dcf

fix(pre-commit): add Go bin to PATH for golangci-lint

7b2cce1

fix(inventory): remove os.Exit to allow defer cleanup

7ccd3c8

ci: migrate to pre-commit for consistent linting across local and CI

1d8e443

style(inventory): apply goimports formatting

0373f34

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Chore/refactor with enhancements#37

Chore/refactor with enhancements#37
basebandit wants to merge 29 commits into
mainfrom
chore/refactor-with-enhancements

basebandit commented Feb 4, 2026

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI commented Feb 9, 2026

Uh oh!

Copilot AI commented Feb 9, 2026

Uh oh!

Copilot AI commented Feb 9, 2026

Uh oh!

Copilot AI commented Feb 9, 2026

Uh oh!

Copilot AI commented Feb 9, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

basebandit commented Feb 4, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI commented Feb 9, 2026

Uh oh!

Copilot AI commented Feb 9, 2026

Uh oh!

Copilot AI commented Feb 9, 2026

Uh oh!

Copilot AI commented Feb 9, 2026

Uh oh!

Copilot AI commented Feb 9, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants