Skip to content

Bump axios to 1.20.0 (high-severity advisories) - #304

Merged
amitbardos merged 1 commit into
mainfrom
fix/axios-1.20
Oct 4, 2026
Merged

amitbardos merged 1 commit into
mainfrom
fix/axios-1.20

Conversation

@amitbardos

Copy link
Copy Markdown
Contributor

npm audit --omit=dev --audit-level=high fails on axios 1.18.1. GHSA-vh66-26gq-q6x8 and 11 more advisories cover >= 1.7.0, < 1.20.0 and are fixed in 1.20.0. This is why the audit is red on open PRs (e.g. #303).

  • axios ^1.18.1 → ^1.20.0. 1.20.0 was released 2026-08-26, outside .npmrc's 14-day min-release-age. form-data was already at 4.0.6 in the lockfile. No other changes.
  • axios 1.20 types method results with a conditional type (AxiosResponseResult) that TypeScript can't infer from a generic T. That broke the build in entities.get/create/update. These now cast to Promise<T>, which is what the response interceptor already returns (response.data). No runtime change.

Tested locally: build, type tests, lint, 315 unit tests, npm audit --omit=dev --audit-level=high (0 vulnerabilities).

#303 moves package.json to packages/sdk. Whichever merges second needs a small rebase.

🤖 Generated with Claude Code

npm audit fails on axios 1.18.1 (GHSA-vh66-26gq-q6x8 and others, all
fixed in 1.20.0). axios 1.20 resolves method return types through a
conditional type that TypeScript can't infer from a generic entity
type, so get/create/update cast to the type the response interceptor
already returns.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@github-actions

github-actions Bot commented Oct 4, 2026

Copy link
Copy Markdown
Contributor

🚀 Package Preview Available!


Install this PR's preview build with npm:

npm i @base44-preview/sdk@0.8.52-pr.304.d2a318a

Prefer not to change any import paths? Install using npm alias so your code still imports @base44/sdk:

npm i "@base44/sdk@npm:@base44-preview/sdk@0.8.52-pr.304.d2a318a"

Or add it to your package.json dependencies:

{
  "dependencies": {
    "@base44/sdk": "npm:@base44-preview/sdk@0.8.52-pr.304.d2a318a"
  }
}

Preview published to npm registry — try new features instantly!

@amitbardos
amitbardos marked this pull request as ready for review October 4, 2026 10:34
@amitbardos
amitbardos merged commit c9a4828 into main Oct 4, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants