Repository navigation
Bump axios to 1.20.0 (high-severity advisories) - #304
Merged
Merged
Conversation
npm audit fails on axios 1.18.1 (GHSA-vh66-26gq-q6x8 and others, all fixed in 1.20.0). axios 1.20 resolves method return types through a conditional type that TypeScript can't infer from a generic entity type, so get/create/update cast to the type the response interceptor already returns. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Contributor
🚀 Package Preview Available!Install this PR's preview build with npm: npm i @base44-preview/sdk@0.8.52-pr.304.d2a318aPrefer not to change any import paths? Install using npm alias so your code still imports npm i "@base44/sdk@npm:@base44-preview/sdk@0.8.52-pr.304.d2a318a"Or add it to your {
"dependencies": {
"@base44/sdk": "npm:@base44-preview/sdk@0.8.52-pr.304.d2a318a"
}
}
Preview published to npm registry — try new features instantly! |
ronnyrin
approved these changes
Oct 4, 2026
amitbardos
marked this pull request as ready for review
October 4, 2026 10:34
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
npm audit --omit=dev --audit-level=highfails onaxios1.18.1. GHSA-vh66-26gq-q6x8 and 11 more advisories cover>= 1.7.0, < 1.20.0and are fixed in 1.20.0. This is why the audit is red on open PRs (e.g. #303).axios^1.18.1→^1.20.0. 1.20.0 was released 2026-08-26, outside.npmrc's 14-daymin-release-age.form-datawas already at 4.0.6 in the lockfile. No other changes.AxiosResponseResult) that TypeScript can't infer from a genericT. That broke the build inentities.get/create/update. These now cast toPromise<T>, which is what the response interceptor already returns (response.data). No runtime change.Tested locally: build, type tests, lint, 315 unit tests,
npm audit --omit=dev --audit-level=high(0 vulnerabilities).#303 moves
package.jsontopackages/sdk. Whichever merges second needs a small rebase.🤖 Generated with Claude Code