Skip to content

Pin the tanstack-start deploy workflow's actions to commit SHAs - #17

Merged
netanelgilad merged 6 commits into
mainfrom
claude/inspiring-edison-55ncqj
Oct 21, 2026
Merged

netanelgilad merged 6 commits into
mainfrom
claude/inspiring-edison-55ncqj

Conversation

@netanelgilad

Copy link
Copy Markdown
Collaborator

Summary

The first manual run of Deploy tanstack-start (from #16) ended in startup_failure, before any job started. The workflow referenced actions/checkout@v4 and actions/setup-node@v4 by tag, and the org only allows actions pinned to a full commit SHA. The same thing happened today in base44/javascript-sdk: its one tag-referenced workflow, "Check Wix Gateway Proxy", also ended in startup_failure.

This pins both actions to the SHAs the CLI repo's workflows already use:

  • actions/checkout@11d5960a326750d5838078e36cf38b85af677262 # v4
  • actions/setup-node@49933ea5288caeca8642d1e84afbd3f7d6820020 # v4

Testing

  • The workflow YAML parses.
  • I can't run the workflow from here. After merge, run it from the Actions tab: it needs the BASE44_API_KEY secret and the TANSTACK_START_APP_ID variable.

Generated by Claude Code

The org only runs actions pinned to a full commit SHA, so the `@v4` tags made
the first run end in startup_failure before any job started. Same SHAs as the
CLI repo's workflows.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01Tmb4PCrrV2SLRpBjkGAgXJ
@netanelgilad netanelgilad self-assigned this Oct 21, 2026

Copy link
Copy Markdown
Collaborator Author

The deploy run on 76a85e5 failed at the new settings check: Add the TANSTACK_START_APP_ID repository variable. That's expected until the variable is set. The earlier run on de9fbeb got past the action pinning and failed in base44 deploy with App id cannot be empty, because the variable is missing. The pinning fix in this PR works. To unblock, add TANSTACK_START_APP_ID under Settings → Secrets and variables → Actions → Variables, then re-run the workflow.


Generated by Claude Code

Copy link
Copy Markdown
Collaborator Author

With the app ID variable set, the deploy run on 76a85e5 deployed and published the app: production serves commit 76a85e5 at https://tan-stack-guestbook-a1938540.base44.app, and the page renders the guestbook. The job still exited 1 at the very end with Error fetching site URL: Unauthorized. ['api_key'] -> Object not found. After publishing, CLI 0.2.0 looks up the app's URL on a platform route that refuses workspace API keys. That's a CLI bug, not this PR's. The fix is in base44/cli#671. Once it's released, I'll bump the base44@0.2.0 pin in the workflow.


Generated by Claude Code

Copy link
Copy Markdown
Collaborator Author

The deploy run on feb8356 failed in the new Link the Base44 app step, at Error listing projects: Unauthorized. ['api_key'] -> Object not found. base44 link --app-id looks the app up by listing apps through GET /api/apps, which refuses a workspace API key (the same gap as published-url, fixed in base44/cli#671). The step scoping itself works: the app ID reached only the link step, and the key only link and deploy. The fix belongs in the CLI: with --app-id, check that single app instead of listing everything. Waiting on a decision about that CLI change before this can go green.


Generated by Claude Code

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01Tmb4PCrrV2SLRpBjkGAgXJ
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants