test(e2e): scaffold Playwright suite with a non-blocking CI job - #109
Merged
Conversation
Adds a home-page smoke test and a non-blocking `e2e` CI job so we can build out journey coverage incrementally without gating merges on it. Includes a temporary failing test to confirm the CI job uploads the screenshot/trace artifact on failure — will be removed once verified.
Collaborator
🟡 Heimdall Review Status
|
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Vitest's default include pattern matches any *.spec.ts, so it was picking up the new Playwright specs and failing on their test() fixture API. Caught by CI on the e2e scaffolding PR.
Confirmed on this PR: the e2e job runs non-blocking, home.spec.ts passes, and the playwright-report artifact captures a screenshot and trace on failure.
Explains the two suites' distinct purposes, and calls out that e2e coverage is for stable, settled surfaces (e.g. home page, core nav) — not for demos still under active iteration, where churn would make the test pure maintenance overhead.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
e2e/,playwright.config.ts) with one real test that loads the home page and checks the landing copy/Vibenet link render.e2eCI job (continue-on-error: true) that builds, serves, and runs the suite against a production build, uploading the HTML report (with screenshots/traces on failure) as an artifact.e2e/**from vitest's default test glob (vitest.config.mts), which was otherwise picking up the Playwright specs and failing on theirtest()fixture API.Test plan
npm run test:e2epasses locally forhome.spec.tsnpm run test/npm run typecheck/npm run lintcleane2ejob runs and is non-blocking, and a deliberately failing test (since removed) proved theplaywright-reportartifact captures a screenshot + trace on failure