docs(changelog): clarify seize integrator guidance - #205
Open
rayyan224 wants to merge 5 commits into
Open
Conversation
Reframe the seize changelog's integrator implications around concrete pool-level exposure and preserve the burnBlocked context so readers can distinguish the new surface from the pre-existing risk. Co-authored-by: Cursor <cursoragent@cursor.com>
rayyan224
requested review from
amiecorso,
eric-ships,
ilikesymmetry and
stevieraykatz
as code owners
August 20, 2026 18:37
Interface Coverage✅ All interface functions have test coverage. |
📊 Forge Coverage (
|
| File | Lines | Stmts | Branches | Funcs |
|---|---|---|---|---|
| 🟡 B20FactoryLib.sol | 97.70% | 98.00% | 100.00% | 95.00% |
| 🔴 test/lib/ForceFeeder.sol | 0.00% | 0.00% | 100.00% | 0.00% |
| 🔴 test/lib/PrecompileProbe.sol | 0.00% | 0.00% | 0.00% | 0.00% |
| 🟢 MockActivationRegistry.sol | 100.00% | 100.00% | 100.00% | 100.00% |
| 🟢 MockActivationRegistryStorage.sol | 100.00% | 100.00% | 100.00% | 100.00% |
| 🟢 MockB20.sol | 100.00% | 100.00% | 100.00% | 100.00% |
| 🟢 MockB20Asset.sol | 100.00% | 100.00% | 100.00% | 100.00% |
| 🟡 MockB20Factory.sol | 98.96% | 99.10% | 100.00% | 100.00% |
| 🟢 MockB20Stablecoin.sol | 100.00% | 100.00% | 100.00% | 100.00% |
| 🟢 MockB20Storage.sol | 100.00% | 100.00% | 100.00% | 100.00% |
| 🟡 MockPolicyRegistry.sol | 100.00% | 99.54% | 97.67% | 100.00% |
| 🟢 MockPolicyRegistryStorage.sol | 100.00% | 100.00% | 100.00% | 100.00% |
| Total | 97.07% | 97.52% | 98.16% | 97.00% |
Full report: download artifact. To browse locally: make coverage (runs forge coverage + genhtml + opens the HTML report).
rayyan224
commented
Aug 20, 2026
rayyan224
commented
Aug 20, 2026
✅ Fork tests: all 721 passedbase/base is fully in sync with the base-std spec. |
Address the PR feedback by reframing the integrator impact in terms of funds moving outside the regular transfer flow and by simplifying the policy-ID exposure check as a point-in-time signal rather than a guarantee. Co-authored-by: Cursor <cursoragent@cursor.com>
Remove the monitoring and incident-response paragraph from the integrator section so the entry stays focused on the core exposure explanation and immediate policy checks. Co-authored-by: Cursor <cursoragent@cursor.com>
Drop the structural-assessment tangent so the integrator section stays focused on the direct policy check and its limits. Co-authored-by: Cursor <cursoragent@cursor.com>
rayyan224
requested review from
robriks and
stephancill
and
a lite review from Copilot
August 20, 2026 20:33
There was a problem hiding this comment.
Pull request overview
Updates the Cobalt B20 seizeWithMemo changelog entry to better communicate integrator impact and operational guidance, especially for pooled-balance systems where balances can change outside the usual transfer pathways.
Changes:
- Adds an “Implications for Integrators” section describing pool-level accounting impact for
seizeWithMemo/burnBlocked. - Clarifies that exposure already existed via
burnBlocked, and thatseizeWithMemoprimarily changes the operational path and event signaling. - Adds concrete guidance for issuers to assess point-in-time exposure via
policyId(...)and Policy Registry authorization checks.
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
burnBlockedand thatseizeWithMemochanges the operational path and signalTest plan
Made with Cursor