docs(changelog): composite-policy written spec + template example rename - #204
Merged
rayyan224 merged 3 commits intoAug 18, 2026
Merged
Conversation
Converts the COMPOSITE_POLICY.md point-form draft into a full written changelog entry at changelog/02_Cobalt_PolicyRegistry_composite_policy.md, verified against src/interfaces/IPolicyRegistry.sol. Co-Authored-By: Claude <noreply@anthropic.com>
Interface Coverage✅ All interface functions have test coverage. |
📊 Forge Coverage (
|
| File | Lines | Stmts | Branches | Funcs |
|---|---|---|---|---|
| 🟡 B20FactoryLib.sol | 97.70% | 98.00% | 100.00% | 95.00% |
| 🔴 test/lib/ForceFeeder.sol | 0.00% | 0.00% | 100.00% | 0.00% |
| 🔴 test/lib/PrecompileProbe.sol | 0.00% | 0.00% | 0.00% | 0.00% |
| 🟢 MockActivationRegistry.sol | 100.00% | 100.00% | 100.00% | 100.00% |
| 🟢 MockActivationRegistryStorage.sol | 100.00% | 100.00% | 100.00% | 100.00% |
| 🟢 MockB20.sol | 100.00% | 100.00% | 100.00% | 100.00% |
| 🟢 MockB20Asset.sol | 100.00% | 100.00% | 100.00% | 100.00% |
| 🟡 MockB20Factory.sol | 98.96% | 99.10% | 100.00% | 100.00% |
| 🟢 MockB20Stablecoin.sol | 100.00% | 100.00% | 100.00% | 100.00% |
| 🟢 MockB20Storage.sol | 100.00% | 100.00% | 100.00% | 100.00% |
| 🟡 MockPolicyRegistry.sol | 100.00% | 99.54% | 97.67% | 100.00% |
| 🟢 MockPolicyRegistryStorage.sol | 100.00% | 100.00% | 100.00% | 100.00% |
| Total | 97.07% | 97.52% | 98.16% | 97.00% |
Full report: download artifact. To browse locally: make coverage (runs forge coverage + genhtml + opens the HTML report).
Keeps changelog/COMPOSITE_POLICY.md in place and adds a copy at changelog/TEMPLATE_COMPOSITE_POLICY.md, alongside the generic changelog/TEMPLATE_POINT_FORM.md, so both remain visible for comparison. Co-Authored-By: Claude <noreply@anthropic.com>
rayyan224
force-pushed
the
changelog/cobalt-policy-registry-composite-policy-spec
branch
from
August 18, 2026 15:35
d30d628 to
fc58c27
Compare
❌ Fork tests did not runThe build or setup step failed before any tests could execute. Check the workflow logs for details. |
rayyan224
commented
Aug 18, 2026
| @@ -0,0 +1,226 @@ | |||
| # ADR Template (Point Form) | |||
Collaborator
Author
There was a problem hiding this comment.
Will be removed for prod, here to show how it works / generated from
rayyan224
commented
Aug 18, 2026
|
|
||
| ## Summary | ||
|
|
||
| - Introduce two new `PolicyRegistry` policy types, `UNION` (OR) and `INTERSECT` (AND) — collectively |
Collaborator
Author
There was a problem hiding this comment.
This is what the devloper fills out
rayyan224
commented
Aug 18, 2026
| @@ -0,0 +1,232 @@ | |||
| # Composite Policies (UNION/INTERSECT) | |||
Collaborator
Author
There was a problem hiding this comment.
Long Form Document
stephancill
reviewed
Aug 18, 2026
Co-authored-by: Stephan Cilliers <stephan.cilliers@coinbase.com>
rayyan224
marked this pull request as ready for review
August 18, 2026 18:57
rayyan224
requested review from
amiecorso,
eric-ships,
ilikesymmetry and
stevieraykatz
as code owners
August 18, 2026 18:57
rayyan224
deleted the
changelog/cobalt-policy-registry-composite-policy-spec
branch
August 18, 2026 18:57
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
changelog/02_Cobalt_PolicyRegistry_composite_policy.md, generated from the point-form draft via thetechnical-documentskill and verified againstsrc/interfaces/IPolicyRegistry.sol.changelog/COMPOSITE_POLICY.mdtochangelog/TEMPLATE_COMPOSITE_POLICY.md, keeping the filled-in point-form draft as a worked example alongside the genericchangelog/TEMPLATE_POINT_FORM.md, now that the feature has its own written entry.Test plan
changelog/README.mdindex entry for PolicyRegistry composite policies still resolves to02_Cobalt_PolicyRegistry_composite_policy.mdmain