Repository navigation
Export measured rivers and coasts in default settlement previews - #84
Merged
Merged
Conversation
✅ Deploy Preview for bazgaars-fmg ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Erdemeli’s preview omitted the Enova River because normal FMG builds still used the legacy ocean-bearing-only exporter. Enable measured coast and river export by default, retaining the endpoint override for local deployments, and scale the initial survey with city population so large settlements have enough surrounding geography.
The supplied Vinhia save also exercises pointed and crossing saved shorelines. Validate those using local Bézier control hulls and bounded intersection error, then compact scanline fill pieces and arithmetic coordinate tails without closing channels or filling islands. Unsafe geometry and oversized URLs still fail visibly instead of falling back to invented water.
Validation: 128 focused exporter, shoreline and packing tests; both Vinhia saves exported with the default production endpoint (updated preview: 7,796 bytes of the 8,192-byte budget); generated Erdemeli with both ocean and Enova River and all 173,976 residents assigned; desktop and portrait renderer checks including zoom-out and panning. Full TypeScript checking retains the existing 11 Quill declaration errors.
Existing bearing-only links must be regenerated from the source map. Both the original Vinhia save and its subsequently smoothed coastline were checked. The updated coastline exports as a connected ocean polygon reaching the survey boundary. River width remains explicitly identified as an estimate from FMG’s physical width model.