Repository navigation
Export measured coasts and smooth local rivers for Settlemaker cities - #83
Merged
Merged
Conversation
Survey water around city burgs, retain local river identity and widths, and transmit smooth source curves for riverfront planning. Preserve river geometry through the preview API with bounded survey metadata and explicit approximation diagnostics.
✅ Deploy Preview for bazgaars-fmg ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Settlemaker city previews could lose nearby river geometry or receive a coarse angular course without enough information to place a river port. Export measured coastal surveys for cities and smooth, locally sampled river courses with source provenance, local width estimates and the intended harbour river identity.
The existing measured-water endpoint remains an explicit build-time opt-in. Survey bounds, width approximation diagnostics and URL size limits remain enforced. The matching Settlemaker change uses this geometry to place the city beside the river and connect its opposite-bank suburbs.
Validation: 106 focused exporter, survey, curve and unit tests; native Biome 2.5.12 lint and version/asset hook checks. Full TypeScript checking still reports the same 11 pre-existing Quill errors.