Repository navigation
fix: highlight PHP hunks without an opening tag - #496
Merged
Merged
Conversation
barrettruth
force-pushed
the
fix/php-hunk-highlighting
branch
from
November 9, 2026 14:34
896c959 to
e5b0a61
Compare
2 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
PHP hunks rarely contain the file's
<?phptag, so thephpgrammar parses them as HTML. Pure-PHP lines get wrong HTML colors, or Vim syntaxErrorgroups when no parser is installed.Solution
When a hunk has no PHP tag, or
?>comes before any open tag, add a<?phpline before parsing and shift rows by one. This applies to both hunk sides, the@@function header, and the Vim syntax fallback.This has some performance implications - only for PHP at least.
Closes #495