Skip to content

refactor [Scrutinizer Sourceforge] to use routeEnum - #12169

Merged
jNullj merged 5 commits into
badges:masterfrom
jNullj:route-enum-refactor-p9
Sep 16, 2026
Merged

jNullj merged 5 commits into
badges:masterfrom
jNullj:route-enum-refactor-p9

Conversation

@jNullj

@jNullj jNullj commented Sep 13, 2026

Copy link
Copy Markdown
Member

A follow-up of #11800 & a condition for #11371

SourceforgeOpenTicket had an enum in the second pattern param, so i migrated the enum logic to the handle for this one.

@jNullj jNullj added the core Server, BaseService, GitHub auth, Shared helpers label Sep 13, 2026
@github-actions

github-actions Bot commented Sep 13, 2026

Copy link
Copy Markdown
Contributor
Warnings
⚠️ This PR modified service code for scrutinizer but not its test code.
That's okay so long as it's refactoring existing code.
⚠️ This PR modified service code for sourceforge but not its test code.
That's okay so long as it's refactoring existing code.
Messages
📖 ✨ Thanks for your contribution to Shields, @jNullj!

Generated by 🚫 dangerJS against cba9e4d

@jNullj
jNullj marked this pull request as ready for review September 13, 2026 19:37
Comment thread services/sourceforge/sourceforge-open-tickets.service.js
@jNullj
jNullj requested a review from PyvesB September 14, 2026 18:34
@jNullj
jNullj added this pull request to the merge queue Sep 16, 2026
Merged via the queue into badges:master with commit 103e8e3 Sep 16, 2026
47 checks passed
@jNullj
jNullj deleted the route-enum-refactor-p9 branch September 16, 2026 05:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

core Server, BaseService, GitHub auth, Shared helpers

Development

Successfully merging this pull request may close these issues.

3 participants