Skip to content

fix: chart marks land at full strength; release 0.1.1 - #99

Merged
b4rb13 merged 2 commits into
mainfrom
fix/chart-handoff-fade
Nov 20, 2026
Merged

b4rb13 merged 2 commits into
mainfrom
fix/chart-handoff-fade

Conversation

@b4rb13

@b4rb13 b4rb13 commented Nov 20, 2026

Copy link
Copy Markdown
Owner

Summary

 LoadingController #start, shared-clock path (dense chart/table handoffs, custom bindings)
-  placeholder layer: opacity 1 → 0 across the whole handoff, eased
+  placeholder layer: opacity 1 until 90% of the handoff, then → 0 (eased last step)
   content layer: unchanged (the chart's own reveal drives it)

With a chart placeholder, the chart draws its own marks gliding onto the line, and removes them where the line wipes in. The region also faded its whole placeholder layer over the same time, so the marks reached the line at a third to half strength. The layer now holds until the chart's marks have left. A custom handoff that leaves its marks on screen still fades out in the last tenth.

The home page's workaround (::part(placeholder) { opacity: 1 !important } in Family.astro) is removed.

Release: the second commit runs bunx changeset version, taking both packages to 0.1.1. Merging stages them through the new Release workflow, which is the first real use of trusted publishing. Then the owner approves each version with 2FA on npmjs.com.

Evidence

  • Before: a chart placeholder keeps its marks at full strength while they land on the line read the placeholder layer at 0.33 (and 0.47 in the first fix attempt).
    After: 1.0 at landing and at 83% of the handoff. It passed 4× in a row.
  • bun run test:e2e: 870 passed. bun run lint, check and test pass, and bun run size stays within every budget.
  • bun run release:check: dotquilt@0.1.1 and @dotquilt/react@0.1.1, no publishing blockers.

Merge Danger

Door: one-way for the release, two-way for the code

A staged version can be rejected before it goes public. Once approved, the 0.1.1 version number is used up.

Blast Radius: chart handoffs

Every chart (and custom) handoff in a region now keeps its placeholder layer opaque until the end.

🤖 Generated with Claude Code

b4rb13 and others added 2 commits November 20, 2026 23:18
A region with a chart placeholder used the shared-clock handoff path,
which faded the whole placeholder layer from 1 to 0 across the handoff.
The chart draws its own marks and removes them where its line wipes in,
so the extra fade meant the marks reached the line at a third to half
strength. The layer now holds at full strength and lets go only in the
last tenth of the handoff, eased; any custom handoff that leaves its marks
on screen still fades out at the end.

The regression test samples the placeholder layer during a slowed chart
handoff: 0.33 at landing before the fix, 1 after. The home page's
workaround (::part(placeholder) { opacity: 1 !important }) is gone.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@vercel

vercel Bot commented Nov 20, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
dotquilt Ready Ready Preview Nov 20, 2026 7:18pm UTC

Request Review

@b4rb13
b4rb13 merged commit 751e7de into main Nov 20, 2026
9 checks passed
@b4rb13
b4rb13 deleted the fix/chart-handoff-fade branch November 20, 2026 19:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant