Repository navigation
fix: chart marks land at full strength; release 0.1.1 - #99
Merged
Merged
Conversation
A region with a chart placeholder used the shared-clock handoff path,
which faded the whole placeholder layer from 1 to 0 across the handoff.
The chart draws its own marks and removes them where its line wipes in,
so the extra fade meant the marks reached the line at a third to half
strength. The layer now holds at full strength and lets go only in the
last tenth of the handoff, eased; any custom handoff that leaves its marks
on screen still fades out at the end.
The regression test samples the placeholder layer during a slowed chart
handoff: 0.33 at landing before the fix, 1 after. The home page's
workaround (::part(placeholder) { opacity: 1 !important }) is gone.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
With a chart placeholder, the chart draws its own marks gliding onto the line, and removes them where the line wipes in. The region also faded its whole placeholder layer over the same time, so the marks reached the line at a third to half strength. The layer now holds until the chart's marks have left. A custom handoff that leaves its marks on screen still fades out in the last tenth.
The home page's workaround (
::part(placeholder) { opacity: 1 !important }in Family.astro) is removed.Release: the second commit runs
bunx changeset version, taking both packages to 0.1.1. Merging stages them through the new Release workflow, which is the first real use of trusted publishing. Then the owner approves each version with 2FA on npmjs.com.Evidence
a chart placeholder keeps its marks at full strength while they land on the lineread the placeholder layer at 0.33 (and 0.47 in the first fix attempt).After: 1.0 at landing and at 83% of the handoff. It passed 4× in a row.
bun run test:e2e: 870 passed.bun run lint,checkandtestpass, andbun run sizestays within every budget.bun run release:check:dotquilt@0.1.1and@dotquilt/react@0.1.1, no publishing blockers.Merge Danger
Door: one-way for the release, two-way for the code
A staged version can be rejected before it goes public. Once approved, the 0.1.1 version number is used up.
Blast Radius: chart handoffs
Every chart (and custom) handoff in a region now keeps its placeholder layer opaque until the end.
🤖 Generated with Claude Code