Repository navigation
Drop the Google Fonts mock from the menu tests - #106
Merged
Merged
Conversation
The site serves its own fonts since #103, so no page requests Google Fonts and the mock in menu.spec.ts (written before that merged) did nothing. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
tests/site/menu.spec.ts -test.beforeEach(… page.route('https://fonts.googleapis.com/**', …))#104 was written before #103 moved the fonts onto the site, so its tests still mocked a request no page makes any more. The other site tests dropped the same mock in #103.
Evidence
bunx playwright test --project=site-chromium tests/site/menu.spec.ts: 9 passed.tests/site/discovery.spec.tsalready checks that pages make no request to another origin.Merge Danger
Door: two-way
Blast Radius: none (one test file)
🤖 Generated with Claude Code