Skip to content

Drop the Google Fonts mock from the menu tests - #106

Merged
b4rb13 merged 1 commit into
mainfrom
chore/menu-test-fonts
Nov 20, 2026
Merged

b4rb13 merged 1 commit into
mainfrom
chore/menu-test-fonts

Conversation

@b4rb13

@b4rb13 b4rb13 commented Nov 20, 2026

Copy link
Copy Markdown
Owner

Summary

 tests/site/menu.spec.ts
-test.beforeEach(… page.route('https://fonts.googleapis.com/**', …))

#104 was written before #103 moved the fonts onto the site, so its tests still mocked a request no page makes any more. The other site tests dropped the same mock in #103.

Evidence

  • bunx playwright test --project=site-chromium tests/site/menu.spec.ts: 9 passed.
  • tests/site/discovery.spec.ts already checks that pages make no request to another origin.

Merge Danger

Door: two-way

Blast Radius: none (one test file)

🤖 Generated with Claude Code

The site serves its own fonts since #103, so no page requests Google Fonts
and the mock in menu.spec.ts (written before that merged) did nothing.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@vercel

vercel Bot commented Nov 20, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
dotquilt Ready Ready Preview Nov 20, 2026 10:28pm UTC

Request Review

@b4rb13
b4rb13 merged commit d266b64 into main Nov 20, 2026
7 checks passed
@b4rb13
b4rb13 deleted the chore/menu-test-fonts branch November 20, 2026 22:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant