fix: Recent Documents sidebar can be closed from its header - #21
Open
Coriou wants to merge 1 commit into
Open
Conversation
The sidebar could be opened from the floating capsule but had no in-panel close. Header collapse clones the trash button (sidebar.leading, inverse of the overlay); MarkdownView still owns the flag; ⇧⌘D still toggles.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Me again with a half-baked, visually untested PR.
Once the Recent Documents sidebar is open, there is no in-panel way to close it. Shift-Cmd-D still toggles it; this just adds a collapse control on the Documents header (same icon as the floating capsule, inverse verb).
Still no Xcode on this machine, so I have not seen it run. The button clones the existing trash control. MarkdownView still owns the flag.
Two more PRs coming on the same theme:
If you can't be bothered to clean up after me, I'll take care of it when I get home.