Open
Conversation
Previously, when integrating Formhandler through TypoScript, the
settings were not used:
```
lib.Foo = EXTBASEPLUGIN
lib.Foo {
extensioName = Formhandler
plugin = Pi1
settings {
# These settings get ignored
...
}
}
```
This change passes the settings along and merges them with other
configuration. It's accessing the internal TypoScriptService class to
emulate old behaviour. It is not deeply tested yet, but might suffice.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, when integrating Formhandler through TypoScript, the settings were not used:
This change passes the settings along and merges them with other configuration. It's accessing the internal TypoScriptService class to emulate old behaviour. It is not deeply tested yet, but might suffice.
(I am not sure about the current state and roadmap of this repository yet, but most things seem to work, apart from the now missing IsInDBTable, which I can restore)