[BUGFIX] Keep AI marker on reviewed images, only hide it for text - #36
Merged
Conversation
AiLabelPartialTest only ever fed the partial a record, so the file branch, the one whose review rule this change actually flips, was covered indirectly at best, through ImageOverlayPartialTest rendering Media/Rendering/Image. This adds a renderPartialForFile() counterpart plus the three cases that pin the rule down: a flagged file renders the marker, a flagged *and reviewed* file still renders it (unlike a reviewed record, which must not), and an unflagged file renders nothing. No file on disk is needed. The partial only reads metadata properties, and getProperty() never touches the filesystem. Additionally, the labels are adjusted as they were no longer true.
o-ba
approved these changes
Sep 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.