Repository navigation
Conversation
- Add src/i18n/zh.ts with 1294 translated strings keyed by the English source - Register zh in the catalog map and detect zh* system locales - Add 中文 to the in-app language picker (Settings -> Language) - Use zh-CN for on-device text-to-speech when Chinese is selected - Mention Simplified Chinese in the README
Author
|
Hi — thanks for the app, it's the only Hermes client I've found that covers the whole backend surface, and it's what I use daily. This PR adds a Simplified Chinese (zh-Hans) UI on top of the existing
If any terminology is off ( Two notes:
No rush on review — just didn't want this to sit unread. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds a Simplified Chinese (zh-Hans) UI to the app, following the existing i18n pattern (English source strings as keys, same as
tr).src/i18n/zh.ts— 1294 translated strings covering every key returned bynode scripts/extract-strings.mjs(1307 total; 13 are pure technical terms such asCPU,PDF,Webhooks,exit {code}and are intentionally left as-is)src/i18n/index.ts— register thezhcatalog;resolveLanguagenow maps anyzh*system locale tozh(previously anything non-trfell back to English)src/store/settings.ts—Languagegains'zh'src/app/settings.tsx— add中文to the language picker (System / English / Türkçe / 中文)src/lib/voice.ts— on-device TTS useszh-CNwhen Chinese is selectedsrc/components/FeatureSearch.tsx— searchable keywords for the language rowREADME.md— one line noting Simplified ChineseVerification
npx tsc --noEmit→ clean (exit 0){name}/{n}/{p}/{title}in the source string is present, unchanged, in the translation (0 mismatches across 1307 strings)session=会话,gateway=网关,profile=配置档,skill=技能,cron job=定时任务, …); product names, commands, paths and model ids are not translatedSenZh/hermes-android, tagv1.8.0-zh.3) so the APK can be smoke-tested on a device before mergeNotes
Thanks for the app — it's the only Hermes client I've found that covers the whole backend surface.