XSD Update#4
Open
franz-ms-muc wants to merge 1 commit into
Open
Conversation
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Updates the IEC 61499-related XSDs to loosen some attribute requirements, add ASN.1 tagging metadata, and align network/block models with richer attribute/parameter content.
Changes:
- Relaxed several previously-required attributes and expanded FB/Connection/VarDeclaration content models to allow embedded
Attribute/Parametergroups. - Added
ASN1TagandASN1TagClassschema types to support ASN.1 tagging on data types. - Refactored shared text types (
ST,Other) and adjusted several attribute names/types across schemas.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| src/specs/xsds/fbtype.xsd | Makes several attributes optional and removes local ST/Other type declarations. |
| src/specs/xsds/fbnetwork.xsd | Allows FB to contain Parameter/Attribute elements; extends Connection with AttributeGroup; renames a coordinate attribute. |
| src/specs/xsds/datatype.xsd | Adds ASN1Tag element + supporting types; allows VarDeclaration to contain AttributeGroup. |
| src/specs/xsds/common.xsd | Changes Identification/VersionInfo to simple-content; revises Attribute type; tightens NameCommentAttributes@Name type. |
| src/specs/xsds/block-common.xsd | Reorders Sockets/Plugs sequence items; renames With@var; adds ST/Other type declarations. |
Comments suppressed due to low confidence (1)
src/specs/xsds/fbtype.xsd:1
STandOthertype declarations were removed from this schema (and appear added inblock-common.xsd). Iffbtype.xsdis intended to be consumed/compiled independently, moving these shared types can introduce missing-type errors unless there is a guaranteedxs:include/xs:importchain. Consider centralizing shared types in a common schema that is explicitly included where needed, and avoid having type definitions 'move' between schemas without a stable inclusion strategy.
<?xml version="1.0" encoding="UTF-8"?>
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
25
to
30
| <xs:element name="InputVars" type="InputVars" minOccurs="0" maxOccurs="1"/> | ||
| <xs:element name="OutputVars" type="OutputVars" minOccurs="0" maxOccurs="1"/> | ||
| <xs:element name="InOutVars" type="InOutVars" minOccurs="0" maxOccurs="1"/> | ||
| <xs:element name="Sockets" type="Sockets" minOccurs="0" maxOccurs="1"/> | ||
| <xs:element name="Plugs" type="Plugs" minOccurs="0" maxOccurs="1"/> | ||
| <xs:element name="Sockets" type="Sockets" minOccurs="0" maxOccurs="1"/> | ||
| </xs:sequence> |
|
|
||
| <xs:complexType name="With"> | ||
| <xs:attribute name="var" type="Identifier" use="required"/> | ||
| <xs:attribute name="Var" type="Identifier" use="required"/> |
| <xs:attribute name="dx1" type="Coordinate" use="optional"/> | ||
| <xs:attribute name="dx2" type="Coordinate" use="optional"/> | ||
| <xs:attribute name="y" type="Coordinate" use="optional"/> | ||
| <xs:attribute name="dy" type="Coordinate" use="optional"/> |
|
|
||
| <xs:attributeGroup name="NameCommentAttributes"> | ||
| <xs:attribute name="Name" type="Identifier" use="required"/> | ||
| <xs:attribute name="Name" type="PackageName" use="required"/> |
Comment on lines
+90
to
+93
| <xs:complexType name='Attribute' mixed='true'> | ||
| <xs:attributeGroup ref="NameCommentAttributes"/> | ||
| <xs:attribute name='Type' type='xs:string' use='optional'/> | ||
| <xs:attribute name='Value' type='xs:string' use='optional'/> |
I guess a PR is easier to read. here you go.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I guess a PR is easier to read.
here you go.